Skip to content

DependencyContextLoader should load all dependency files it is given to it #2669

@eerhardt

Description

@eerhardt

Steps to reproduce

After dotnet/sdk#1053 is merged, it is possible for an app to run on the shared framework, but not be "portable". In one of these apps, if you inspect the DependencyContext.Default

Expected behavior

It should have all the framework assemblies, since it runs on the shared framework.

Actual behavior

It doesn't contain the framework assemblies. This is because of this check for IsPortable which is not true for these types of apps.

Notes

We should just load all the dependency files passed through AppContext by the host. Then when other deps files get merged into the app (see #2620 and https://github.com/dotnet/core-setup/issues/624#issuecomment-288245699), the DependencyModel automatically knows about these new deps files.

Metadata

Metadata

Assignees

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions