Skip to content

HTTP2: Race with ping data handling #29986

@geoffkizer

Description

@geoffkizer

Issue is here: https://github.com/dotnet/corefx/blob/28c41fff6f830b8393fd6c7661f33f96aa27f965/src/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Connection.cs#L558

We shouldn't reference _incomingBuffer directly here, as it can change when we read more data into the buffer.

Instead, we should copy the ping data locally (it's always 8 bytes, so ulong would be appropriate) and then pass the copied data to SendPingAckAsync.

See: dotnet/corefx#38226 (comment)

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions