Delete IL verifier from the JIT

[jkotas]

IL verifier is no longer needed in the JIT. Delete tiVerificationNeeded and all code under it.

More context: #32521 (comment)

category:implementation
theme:verification
skill-level:beginner
cost:small
impact:small

[GrabYourPitchforks]

Is there still a scenario where it makes sense for peverify to exist as a stand-alone tool? I'm struggling to think of one aside from checking whether your code contains any dangerous constructs, but even then its incomplete.

[jkotas]

Is there still a scenario where it makes sense for peverify to exist as a stand-alone tool?

Yes, there is. It is tracked by #13827

Note that the RyuJIT IL verifier is not the IL verifier used by PEVerify. RyuJIT IL verifier just gives yes / no answer, without producing the good diagnostic for telling you what is wrong. PEVerify had a completely different implementation of IL verifier.

[jashook]

/cc @BruceForstall @erozenfeld

[AndyAyersMS]

Might be some small throughput benefit, so let's keep in 5.0.

[BruceForstall]

I think it's too late in the product cycle for us to do this. Moving to Future.