Cryptograph.Csp tests are failing intermittently

[jaredpar]

Console Log Summary

  System.Security.Cryptography.Dsa.Tests.DsaArrayOffsetSignatureFormatTests.SignDataVerifyData_SHA1(signatureFormat: Rfc3279DerSequence) [FAIL]
      Assert.True() Failure
      Expected: True
      Actual:   False
      Stack Trace:
        /_/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/DSA/DsaFamilySignatureFormatTests.cs(152,0): at System.Security.Cryptography.Algorithms.Tests.DsaFamilySignatureFormatTests.SignDataVerifyData_SHA1(DSASignatureFormat signatureFormat)

Builds

Build	Pull Request	Test Failure Count
#569968	#33175	1
#570519	#33420	1
#570525	#33990	1
#570636	Rolling	1
#570708	#32592	1
#570791	#33970	1
#570811	#33953	1
#571061	#33984	1
#571274	#34027	1
#571286	Rolling	1
#571338	#33942	1
#571351	#33881	2
#571369	#33831	1

Configurations

• netcoreapp5.0-OSX-Debug-x64-CoreCLR_release-OSX.1013.Amd64.Open
• netcoreapp5.0-OSX-Debug-x64-CoreCLR_release-OSX.1014.Amd64.Open
• netcoreapp5.0-OSX-Debug-x64-Mono_release-OSX.1013.Amd64.Open
• netcoreapp5.0-OSX-Debug-x64-Mono_release-OSX.1014.Amd64.Open
• netcoreapp5.0-Windows_NT-Debug-x64-Mono_release-(Windows.Nano.1809.Amd64.Open)windows.10.amd64.serverrs5.open@mcr.microsoft.com/dotnet-buildtools/prereqs:nanoserver-1809-helix-amd64-08e8e40-20200107182504
• netcoreapp5.0-Windows_NT-Debug-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
• netcoreapp5.0-Windows_NT-Release-x64-CoreCLR_release-Windows.7.Amd64.Open
• netcoreapp5.0-Windows_NT-Release-x64-CoreCLR_release-Windows.81.Amd64.Open

Helix Logs

Build	Pull Request	Console	Core	Test Results
#569968	#33175	console.62a44bd3.log		testResults.xml
#570519	#33420	console.6cc569df.log		testResults.xml
#570525	#33990	console.37ba0ba2.log		testResults.xml
#570636	Rolling	console.79919bed.log		testResults.xml
#570708	#32592	console.474b5dfa.log
#570791	#33970	console.6bc06f50.log		testResults.xml
#570811	#33953	console.f49ee02a.log		testResults.xml
#571061	#33984	console.58ed13a7.log		testResults.xml
#571274	#34027	console.298ca928.log		testResults.xml
#571286	Rolling	console.85804e12.log		testResults.xml
#571338	#33942	console.5c51842e.log		testResults.xml
#571351	#33881	console.aff7c6bf.log		testResults.xml
#571351	#33881	console.60e947ec.log		testResults.xml
#571369	#33831	console.7ecc7dfb.log		testResults.xml

[jaredpar]

@bartonjs ETA for when this will be addressed / disabled? It's continuing to impact our CI reliability.

[bartonjs]

I don't doubt that they're failing, but I've run over two million iterations locally (Win8.1 Server) at this point without encountering a fault. Time to boot up a mac, I guess.

[bartonjs]

When an excess of 10 million iterations succeeds... think laterally.

The DSA Array, DSA Array+Offset, and DSA Span classes are all sharing key objects (similarly for the ECDSA ones, but a different triplet of sharing), so this is race conditions from parallel use on a type that isn't thread-safe.

So I'll have a fix today.