Request for Logging Internals to be public again

[JakenVeina]

Use case: I'd like to have a LoggerMessage.Define() method that accepts more than 5 type args. I'm perfectly happy to implement this myself, by just copying how the others are done, in my own project, and adding more type args. However, the existing implementations rely on the internal LogValuesFormatter class, which used to be public within a .Internals namespace.

For now, my solution is simply to copy/paste the entire LogValuesFormatter class into my own project, which just seems like a waste.

Alternatively, could we simply get LoggerMessage.Define() methods that take more type args? Perhaps up to 8, like Action<T>, Func<T>, ValueTuple<T> etc? Is there some particular performance reason that more than 5 type args would be disadvantageous?

I'm happy to PR this myself, so long as no one is opposed to the change.

[davidfowl]

Alternatively, could we simply get LoggerMessage.Define() methods that take more type args? Perhaps up to 8, like Action, Func, ValueTuple etc? Is there some particular performance reason that more than 5 type args would be disadvantageous?

This sounds reasonable.Would you like to send a PR?

[JakenVeina]

Certainly.

[maryamariyan]

@JakenVeina please note you can now find the Logging source code in the dotnet/runtime repository.

You might want to check these instruction links below:

• How to build runtime repo
• How to update the reference assembly
• Microsoft.Extensions libraries code are now under src/libraries in runtime repo. e.g. LoggerMessage is here and its reference assembly is here.

I'll transfer this issue to runtime repo now.

[maryamariyan]

I just noticed your PR :)