Test failure: profiler\\unittest\\getappdomainstaticaddress\\getappdomainstaticaddress.cmd

[v-haren]

failed in job: runtime-coreclr jitstress 20200526.1

Error message

Unhandled exception. System.ArgumentException: Path "??\h\w\A833091C\w\B2390971\e\profiler\unittest\getappdomainstaticaddress\unloadlibrary.dll" is not an absolute path. (Parameter 'assemblyPath')
 at System.Runtime.Loader.AssemblyLoadContext.LoadFromAssemblyPath(String assemblyPath)
 at Profiler.Tests.Program.LoadCollectibleAssembly() in F:\workspace\_work\1\s\src\coreclr\tests\src\profiler\unittest\getappdomainstaticaddress.cs:line 44
 at Profiler.Tests.Program.RunTest() in F:\workspace\_work\1\s\src\coreclr\tests\src\profiler\unittest\getappdomainstaticaddress.cs:line 33
 at Profiler.Tests.Program.Main(String[] args) in F:\workspace\_work\1\s\src\coreclr\tests\src\profiler\unittest\getappdomainstaticaddress.cs:line 21
Unhandled exception. System.Exception: Profiler tests are expected to contain the text 'PROFILER TEST PASSES' in the console output of the profilee app to indicate a passing test. Usually it is printed from the Shutdown() method of the profiler implementation. This text was not found in the output above.
 at Profiler.Tests.ProfilerTestRunner.LogTestFailure(String error) in F:\workspace\_work\1\s\src\coreclr\tests\src\profiler\common\ProfilerTestRunner.cs:line 137
 at Profiler.Tests.ProfilerTestRunner.Run(String profileePath, String testName, Guid profilerClsid, String profileeArguments, ProfileeOptions profileeOptions) in F:\workspace\_work\1\s\src\coreclr\tests\src\profiler\common\ProfilerTestRunner.cs:line 91
 at Profiler.Tests.Program.Main(String[] args) in F:\workspace\_work\1\s\src\coreclr\tests\src\profiler\unittest\getappdomainstaticaddress.cs:line 26

Return code: 1
Raw output file: C:\h\w\A833091C\w\B2390971\e\profiler\unittest\Reports\profiler.unittest\getappdomainstaticaddress\getappdomainstaticaddress.output.txt
Raw output:
BEGIN EXECUTION
 "C:\h\w\A833091C\p\corerun.exe" getappdomainstaticaddress.dll 
Profiler path: C:\h\w\A833091C\w\B2390971\e\profiler\unittest\getappdomainstaticaddress\Profiler.dll
Profiler path: C:\h\w\A833091C\w\B2390971\e\profiler\unittest\getappdomainstaticaddress\Profiler.dll
Profiler.dll!DllGetClassObject

Test failed: Profiler tests are expected to contain the text 'PROFILER TEST PASSES' in the console output of the profilee app to indicate a passing test. Usually it is printed from the Shutdown() method of the profiler implementation. This text was not found in the output above.
Expected: 100
Actual: -532462766
END EXECUTION - FAILED
FAILED
Test Harness Exitcode is : 1
To run the test:
> set CORE_ROOT=C:\h\w\A833091C\p
> C:\h\w\A833091C\w\B2390971\e\profiler\unittest\getappdomainstaticaddress\getappdomainstaticaddress.cmd
Expected: True
Actual: False


Stack trace
   at profiler_unittest._getappdomainstaticaddress_getappdomainstaticaddress_._getappdomainstaticaddress_getappdomainstaticaddress_cmd() in F:\workspace\_work\1\s\artifacts\tests\coreclr\Windows_NT.x86.Checked\TestWrappers\profiler.unittest\profiler.unittest.XUnitWrapper.cs:line 140

category:correctness
theme:tail-call
skill-level:expert
cost:medium

Tagging subscribers to this area: @tommcdon
Notify danmosemsft if you want to be subscribed.

[BruceForstall]

@tommcdon Possible profiler or profiler test issue? Is this for the diagnostics team?

[tommcdon]

Adding @davmason to take a look

[davmason]

I took a brief look already, but haven't had a chance to root cause this yet. The test code that fails is doing this:

            var collectibleContext = new AssemblyLoadContext("Collectible", true);

            var asmDir = Path.GetDirectoryName(typeof(Program).Assembly.Location);
            var dynamicLibrary = collectibleContext.LoadFromAssemblyPath(Path.Combine(asmDir, "unloadlibrary.dll"));

The fact that the path is bogus is concerning. The profiler is not messing with any part of that call.

It will be a little while before I have more time to spend on this.

[BruceForstall]

The failure mode is CoreCLR Windows_NT x86 Checked tailcallstress @ Windows.10.Amd64.Open. It looks like this test has failed with this failure mode 11 times in the last 2 months, all on Windows x86 with:

set COMPlus_TieredCompilation=0
set COMPlus_TailcallStress=1

This indicates a JIT bug. But why would it happen so few times? This test is run every day.

[davmason]

I am trying to narrow down a repro this morning.

Just running the test on my local machine it has a decent repro rate, maybe one out of 20 times. It does not repro without the profiler attached, after looking at the profiler it is likely because the profiler blocks R2R images, so System.Private.CoreLib is all jitted.

I can get it under a debugger with a little effort, @BruceForstall would a dump be enough to diagnose codegen issues? Right now I'm trying in a loop to see if I can get a TTT trace of it.

[davmason]

I got a trace of it, it looks a lot like a GC hole so far. I am making progress and investigating at this point.