Consider cleaning up Microsoft-System-Net-* diagnostic tracing

[davidsh]

See: #37428 (comment)

It is true that some of the previously ported "Microsoft-System-Net-" events we have are a mess and are inconsistent. I think we can address that. But I would prefer to do that with a separate discussion/issue and not bottleneck on getting this telemetry focused events/counters into dotnet/runtime.
Do we have an issue tracking cleaning that up? It really is a mess.

Tagging subscribers to this area: @dotnet/ncl
Notify danmosemsft if you want to be subscribed.

[karelz]

@davidsh is it something we should tackle in 5.0? Is it going to help end to end scenarios with YARP significantly?

[davidsh]

@davidsh is it something we should tackle in 5.0? Is it going to help end to end scenarios with YARP significantly?

YARP scenarios will benefit from the new telemetry-focused events/counters being added in new namespaces: System.Net.Http, System.Net.Sockets, etc.

These existing events in the "Microsoft-System-Net-*" namespaces are targeted more for debugging/diagnosing. I don't think this is a must have for 5.0.

@stephentoub might have more comments on this since he asked for a tracking issue for this.

[stephentoub]

It's not required for .NET 5, unless its presence is interfering with the actual telemetry we want developers consuming (either from a performance perspective or noise perspective). The majority of the existing tracing is, in my opinion, of very little value and when enabled has overheads, plus it muddies up the codebase.

[karelz]

@davidsh if you can confirm that it does not interfere with end to end telemetry, please move it to Future milestone. Thanks!

[davidsh]

@davidsh if you can confirm that it does not interfere with end to end telemetry, please move it to Future milestone. Thanks!

It's not going to interfere with telemetry. For that scenario we want customers to only use the new event namespaces that will have our new events/counters.

[samsp-msft]

@MihaZupan @karelz - didn't this get resolved with the new events that we added in 6/7?

[MihaZupan]

This issue is referring to the very verbose events we use for diagnostics ourselves (networking team), not the telemetry we added and encourage users to actually use.
They're still around, we just renamed them (e.g. Microsoft-System-Net-Http => Private.InternalDiagnostics.System.Net.Http) to make it clear they're actually different.