Breaking change in ResourceSet class

[sebastienros]

This PR #44104 introduces a breaking change that is only experienced at runtime.
ResourceSet implements IEnumerable and ASP.NET Core is using the contract.

At least there, but other tests break so it might not be isolated.
https://github.com/dotnet/aspnetcore/blob/master/src/Localization/Localization/src/Internal/ResourceManagerStringProvider.cs#L75

While we could react to this change, it doesn't seem that this change of behavior was intentional.

[jkotas]

Revert in #44482

Tagging subscribers to this area: @tarekgh, @buyaa-n, @krwq, @jeffhandley
See info in area-owners.md if you want to be subscribed.

Details

---

Issue meta data

Issue content:	This PR https://github.com//pull/44104 introduces a breaking change that is only experienced at runtime. `ResourceSet` implements `IEnumerable` and ASP.NET Core is using the contract. At least there, but other tests break so it might not be isolated. https://github.com/dotnet/aspnetcore/blob/master/src/Localization/Localization/src/Internal/ResourceManagerStringProvider.cs#L75 While we could react to this change, it doesn't seem that this change of behavior was intentional.
Issue author:	sebastienros
Assignees:	-
Milestone:	-

[marek-safar]

@sebastienros what is the failure?

[sebastienros]

I left all the details on the PR. To summarize ResourceSet implements IEnumerable but the returned elements are not of the same type. They were DictionaryEntry and now they are KeyValuePair<>.

[tarekgh]

@marek-safar here is @sebastienros comment regarding the failure #44104 (comment)

[marek-safar]

I see you are casting object to underlying type. That needs to be fixed on runtime side.

[tarekgh]

@marek-safar just to make sure you saw @jkotas PR reverting your change which broke this scenario #44482

[marek-safar]

Yep, let's revert this to unblock them. I'll fix that in follow up PR (revert)