-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Closed
Labels
area-System.ReflectionenhancementProduct code improvement that does NOT require public API changes/additionsProduct code improvement that does NOT require public API changes/additionshelp wanted[up-for-grabs] Good issue for external contributors[up-for-grabs] Good issue for external contributorsneeds-further-triageIssue has been initially triaged, but needs deeper consideration or reconsiderationIssue has been initially triaged, but needs deeper consideration or reconsideration
Milestone
Description
See comment:
Lines 834 to 836 in e8875e3
| // This assembly should work in netstandard1.3, | |
| // so we cannot use MemberInfo.MetadataToken here. | |
| // Therefore, it compares honestly referring ECMA-335 I.8.6.1.6 Signature Matching. |
With #53283, we won't build a netstandard1.x configuration of this library anymore and the code path can be optimized. FWIW this could have already be done in the past via ifdef compiler directives.
Metadata
Metadata
Assignees
Labels
area-System.ReflectionenhancementProduct code improvement that does NOT require public API changes/additionsProduct code improvement that does NOT require public API changes/additionshelp wanted[up-for-grabs] Good issue for external contributors[up-for-grabs] Good issue for external contributorsneeds-further-triageIssue has been initially triaged, but needs deeper consideration or reconsiderationIssue has been initially triaged, but needs deeper consideration or reconsideration