Logging Generator: messaging fix

[maryamariyan]

Repro code:

public static partial class ABC
{
    [LoggerMessage(EventId = 0, Level = LogLevel.Debug, Message = "{foo}")]
    static partial void M1(ILogger logger);
}

For TemplateHasNoCorrespondingArgument, instead of passing 't' as an argument to the diag method, it should be passing t.Key (the name of the template).

runtime/src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Parser.cs

Line 326 in 43b1f2c

Diag(DiagnosticDescriptors.TemplateHasNoCorrespondingArgument, ma.GetLocation(), t);

Actual

Template [foo, foo] is not provided as argument to the logging method

Expected

Template "foo" is not provided as argument to the logging method

cc: @geeknoid

Tagging subscribers to this area: @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Repro code:

public static partial class ABC
{
    [LoggerMessage(EventId = 0, Level = LogLevel.Debug, Message = "{foo}")]
    static partial void M1(ILogger logger);
}

For TemplateHasNoCorrespondingArgument, instead of passing 't' as an argument to the diag method, it should be passing t.Key (the name of the template).

runtime/src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Parser.cs

Line 326 in 43b1f2c

Diag(DiagnosticDescriptors.TemplateHasNoCorrespondingArgument, ma.GetLocation(), t);

Expected

Template [foo, foo] is not provided as argument to the logging method

Actual

Template "foo" is not provided as argument to the logging method

cc: @geeknoid

Author:	maryamariyan
Assignees:	-
Labels:	area-Extensions-Logging, bug, up-for-grabs
Milestone:	6.0.0

[jeffl8n]

@maryamariyan Are the expected/actual cases flipped? Running the current test without any changes is already returning the expected state.

[maryamariyan]

@maryamariyan Are the expected/actual cases flipped? Running the current test without any changes is already returning the expected state.

hah! yes :) updated