[Mono] Linker generating invalid IL with exception filters

[steveisok]

The exception filters introduced in ab0991e...40ed818#diff-b79affd636899ac98b816c1398f9dca19bc4850a939a3815c09c5a9931094a4c started to make the iOS AOT functional tests fail with:

[System.Net.Http.dll] Unable to compile method 'void System.Net.Http.Http3RequestStream/<SendAsync>d__28:MoveNext ()' due to: 'Invalid IL code in System.Net.Http.Http3RequestStream/<SendAsync>d__28:MoveNext (): IL_05e1: pop 

As a result, the iOS and Catalyst legs are failing on CI.

[steveisok]

/cc @vargaz @lambdageek

[vargaz]

Can you attach the linked assembly ?

[steveisok]

System.Net.Http.dll.zip

[vargaz]

How can I reproduce this ?

[steveisok]

Pull main, build for iOSSimulator, and then build the functional test.

./build.sh -os iOSSimulator -arch x64
./dotnet.sh build /t:Test src/tests/FunctionalTests/iOS/Simulator/AOT /p:TargetOS=iOSSimulator /p:TargetArchitecture=x64

[vargaz]

This is a linker problem, the original IL in '<SendAsync>d__28'::MoveNext is:

            filter
            {
              IL_078c:  isinst     [System.Net.Quic]System.Net.Quic.QuicStreamAbortedException
              IL_0791:  dup
              IL_0792:  brtrue.s   IL_0798

              IL_0794:  pop

while the linked one is:

            filter
            {
              IL_078c:  brtrue.s   IL_0792

              IL_078e:  pop

which is not valid anymore.

[lewing]

cc @agocke @sbomer @eerhardt @marek-safar