Source-build encounters circular PublishBuilder dependency in WasmAppBuilder

[MichaelSimons]

This issue was discovered while updating source-build to the latest 6.0 commit shas - https://github.com/dotnet/installer/pull/11710/files

/repos/tarball1/src/runtime.c300b096419523024f2b807ec9db3c2d91df0298/artifacts/source-build/self/src/src/tasks/WasmAppBuilder/WasmAppBuilder.csproj(33,5): error MSB4006: There is a circular dependency in the target dependency graph involving target "PublishBuilder".

Binlog - runtime.circularbuild.sourcebuild.zip

This is what the call graph looks like:
MSBuild WasmAppBuilder net6.0;net472
WasmAppBuilder net6.0 -> Build
WasmAppBuilder net472 -> publish
MSBuild
Parameters
Projects = WasmAppBuilder.csproj
Targets = Publish
Properties = TargetFramework=net472
Global Properties:
TargetFramework = net472

This appears to be caused by this target in WasmAppBuilder.csproj - https://github.com/dotnet/runtime/blob/release/6.0/src/tasks/WasmAppBuilder/WasmAppBuilder.csproj#L26

  <Target Name="PublishBuilder"
          AfterTargets="Build">

    <!-- needed for publishing with multi-targeting. We are publishing essentially to get the SR.MetadataLoadContext.dll :/ -->
    <ItemGroup>
      <_PublishFramework Include="$(TargetFrameworks)" />
    </ItemGroup>
    <MSBuild Projects="$(MSBuildProjectFile)" Targets="Publish" Properties="TargetFramework=%(_PublishFramework.Identity)" />
  </Target>

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

---

This issue was discovered while updating source-build to the latest 6.0 commit shas - https://github.com/dotnet/installer/pull/11710/files

/repos/tarball1/src/runtime.c300b096419523024f2b807ec9db3c2d91df0298/artifacts/source-build/self/src/src/tasks/WasmAppBuilder/WasmAppBuilder.csproj(33,5): error MSB4006: There is a circular dependency in the target dependency graph involving target "PublishBuilder".

Binlog - runtime.circularbuild.sourcebuild.zip

This is what the call graph looks like:
MSBuild WasmAppBuilder net6.0;net472
WasmAppBuilder net6.0 -> Build
WasmAppBuilder net472 -> publish
MSBuild
Parameters
Projects = WasmAppBuilder.csproj
Targets = Publish
Properties = TargetFramework=net472
Global Properties:
TargetFramework = net472

This appears to be caused by this target in WasmAppBuilder.csproj - https://github.com/dotnet/runtime/blob/release/6.0/src/tasks/WasmAppBuilder/WasmAppBuilder.csproj#L26

  <Target Name="PublishBuilder"
          AfterTargets="Build">

    <!-- needed for publishing with multi-targeting. We are publishing essentially to get the SR.MetadataLoadContext.dll :/ -->
    <ItemGroup>
      <_PublishFramework Include="$(TargetFrameworks)" />
    </ItemGroup>
    <MSBuild Projects="$(MSBuildProjectFile)" Targets="Publish" Properties="TargetFramework=%(_PublishFramework.Identity)" />
  </Target>

Author:	MichaelSimons
Assignees:	-
Labels:	untriaged, area-Infrastructure-mono
Milestone:	-

[MichaelSimons]

cc @safern

[ViktorHofer]

cc @akoeplinger @steveisok

[steveisok]

@radical Would be the best person to look into this.

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

---

This issue was discovered while updating source-build to the latest 6.0 commit shas - https://github.com/dotnet/installer/pull/11710/files

/repos/tarball1/src/runtime.c300b096419523024f2b807ec9db3c2d91df0298/artifacts/source-build/self/src/src/tasks/WasmAppBuilder/WasmAppBuilder.csproj(33,5): error MSB4006: There is a circular dependency in the target dependency graph involving target "PublishBuilder".

Binlog - runtime.circularbuild.sourcebuild.zip

This is what the call graph looks like:
MSBuild WasmAppBuilder net6.0;net472
WasmAppBuilder net6.0 -> Build
WasmAppBuilder net472 -> publish
MSBuild
Parameters
Projects = WasmAppBuilder.csproj
Targets = Publish
Properties = TargetFramework=net472
Global Properties:
TargetFramework = net472

This appears to be caused by this target in WasmAppBuilder.csproj - https://github.com/dotnet/runtime/blob/release/6.0/src/tasks/WasmAppBuilder/WasmAppBuilder.csproj#L26

  <Target Name="PublishBuilder"
          AfterTargets="Build">

    <!-- needed for publishing with multi-targeting. We are publishing essentially to get the SR.MetadataLoadContext.dll :/ -->
    <ItemGroup>
      <_PublishFramework Include="$(TargetFrameworks)" />
    </ItemGroup>
    <MSBuild Projects="$(MSBuildProjectFile)" Targets="Publish" Properties="TargetFramework=%(_PublishFramework.Identity)" />
  </Target>

Author:	MichaelSimons
Assignees:	-
Labels:	arch-wasm, area-Infrastructure-mono
Milestone:	6.0.0

[radical]

Can you try this patch?

diff --git a/src/tasks/WasmAppBuilder/WasmAppBuilder.csproj b/src/tasks/WasmAppBuilder/WasmAppBuilder.csproj
index 7c7377e5c42..a487a4f270a 100644
--- a/src/tasks/WasmAppBuilder/WasmAppBuilder.csproj
+++ b/src/tasks/WasmAppBuilder/WasmAppBuilder.csproj
@@ -25,13 +25,14 @@
   </ItemGroup>
 
   <Target Name="PublishBuilder"
-          AfterTargets="Build">
+          AfterTargets="Build"
+          Condition="'$(_RunningForPublishBuilder)' != 'true'">
 
     <!-- needed for publishing with multi-targeting. We are publishing essentially to get the SR.MetadataLoadContext.dll :/ -->
     <ItemGroup>
       <_PublishFramework Include="$(TargetFrameworks)" />
     </ItemGroup>
-    <MSBuild Projects="$(MSBuildProjectFile)" Targets="Publish" Properties="TargetFramework=%(_PublishFramework.Identity)" />
+    <MSBuild Projects="$(MSBuildProjectFile)" Targets="Publish" Properties="TargetFramework=%(_PublishFramework.Identity);_RunningForPublishBuilder=true" />
   </Target>
 
   <Target Name="GetFilesToPackage" Returns="@(FilesToPackage)">

[MichaelSimons]

Yes, I can give it a try and will report back.

[MichaelSimons]

@radical, I have confirmed your suggested fix addressed the issue.