[wasm] gpath.c:115: assertion 'filename != NULL' failed

[pavelsavara]

Description

Assertion failure during System.Net.Http.Functional.Tests unit test execution.

"most likely it's trying to build a path from an assembly location (which is null in single-file apps). but there are a bunch of places where it would do that."

Reproduction Steps

dotnet.cmd build /p:TargetOS=Browser /p:TargetArchitecture=wasm /p:Configuration=Debug /t:Test src/libraries/System.Net.Http/tests/FunctionalTests

Expected behavior

No assert

Actual behavior

fail: C:/Dev/runtime/src/mono/mono/eglib/gpath.c:115: assertion 'filename != NULL' in the console log

Regression?

No response

Known Workarounds

No response

Configuration

Debug, wasm, chrome

Other information

No response

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

Assertion failure during System.Net.Http.Functional.Tests unit test execution.

"most likely it's trying to build a path from an assembly location (which is null in single-file apps). but there are a bunch of places where it would do that."

Reproduction Steps

dotnet.cmd build /p:TargetOS=Browser /p:TargetArchitecture=wasm /p:Configuration=Debug /t:Test src/libraries/System.Net.Http/tests/FunctionalTests

Expected behavior

No assert

Actual behavior

fail: C:/Dev/runtime/src/mono/mono/eglib/gpath.c:115: assertion 'filename != NULL' in the console log

Regression?

No response

Known Workarounds

No response

Configuration

Debug, wasm, chrome

Other information

No response

Author:	pavelsavara
Assignees:	-
Labels:	arch-wasm
Milestone:	7.0.0

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[lambdageek]

First step would be to get a stack trace. It might also be helpful to run with MONO_LOG_LEVEL=debug, MONO_LOG_MASK=all and check if anything useful gets dumped to the console log

Tagging subscribers to this area:
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

Assertion failure during System.Net.Http.Functional.Tests unit test execution.

"most likely it's trying to build a path from an assembly location (which is null in single-file apps). but there are a bunch of places where it would do that."

Reproduction Steps

dotnet.cmd build /p:TargetOS=Browser /p:TargetArchitecture=wasm /p:Configuration=Debug /t:Test src/libraries/System.Net.Http/tests/FunctionalTests

Expected behavior

No assert

Actual behavior

fail: C:/Dev/runtime/src/mono/mono/eglib/gpath.c:115: assertion 'filename != NULL' in the console log

Regression?

No response

Known Workarounds

No response

Configuration

Debug, wasm, chrome

Other information

No response

Author:	pavelsavara
Assignees:	ilonatommy
Labels:	arch-wasm, area-VM-meta-mono
Milestone:	7.0.0

[lambdageek]

@pavelsavara does the app actually fail after printing that?
It's coming from g_return_val_if_fail (filename != NULL, NULL);
which is a macro like this:

#define g_return_val_if_fail(x,e)  G_STMT_START { if (!(x)) { g_critical ("%s:%d: assertion '%s' failed\n", __FILE__, __LINE__, #x); return (e); } } G_STMT_END

is g_critical fatal on WebAssembly? Or does it just print a scary message to the console and then keep running?

[lambdageek]

I guess what might be happening is that the g_return_val_if_failed is making some real issue. ie: someone calls g_path_get_dirname and passes in null, then the function prints that message and returns null. and then that null causes a problem down the line. So there's no stack trace from the "assertion" message because it's not fatal.

[pavelsavara]

is g_critical fatal on WebAssembly? Or does it just print a scary message to the console and then keep running?

Keeps running. I didn't see any consequences of it.

[lambdageek]

Ok, in that case, this is fixed by #60445