System.Threading.Timer.Timer max timeout mismatch

[zgabi]

Description

In the followin line an exception is thrown when timeout is > 0xfffffffe

runtime/src/libraries/System.Private.CoreLib/src/System/Threading/Timer.cs

Lines 837 to 838 in 57bfe47

	if (dueTm > MaxSupportedTimeout)
	throw new ArgumentOutOfRangeException(nameof(dueTime), SR.ArgumentOutOfRange_TimeoutTooLarge);

runtime/src/libraries/System.Private.CoreLib/src/System/Threading/Timer.cs

Line 803 in 57bfe47

internal const uint MaxSupportedTimeout = 0xfffffffe;

The exception message is:

runtime/src/libraries/System.Private.CoreLib/src/Resources/Strings.resx

Lines 1856 to 1858 in 00c1692

	<data name="ArgumentOutOfRange_TimeoutTooLarge" xml:space="preserve">
	<value>Time-out interval must be less than 2^32-2.</value>
	</data>

Reproduction Steps

Expected behavior

Message should be "less than or equal to 2^32-2" or "less than 2^32-1"

Actual behavior

Wrong exception message

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

In the followin line an exception is thrown when timeout is > 0xfffffffe

runtime/src/libraries/System.Private.CoreLib/src/System/Threading/Timer.cs

Lines 837 to 838 in 57bfe47

	if (dueTm > MaxSupportedTimeout)
	throw new ArgumentOutOfRangeException(nameof(dueTime), SR.ArgumentOutOfRange_TimeoutTooLarge);

runtime/src/libraries/System.Private.CoreLib/src/System/Threading/Timer.cs

Line 803 in 57bfe47

internal const uint MaxSupportedTimeout = 0xfffffffe;

The exception message is:

runtime/src/libraries/System.Private.CoreLib/src/Resources/Strings.resx

Lines 1856 to 1858 in 00c1692

	<data name="ArgumentOutOfRange_TimeoutTooLarge" xml:space="preserve">
	<value>Time-out interval must be less than 2^32-2.</value>
	</data>

Reproduction Steps

Expected behavior

Message should be "less than or equal to 2^32-2" or "less than 2^32-1"

Actual behavior

Wrong exception message

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

Author:	zgabi
Assignees:	-
Labels:	area-System.Threading, untriaged
Milestone:	-

[danmoseley]

Thanks for the report. Would you like to offer a PR?

[zgabi]

If it is not necessary, I prefer not to create a PR.
I think this is easy to fix.

[danmoseley]

@zgabi I fixed it, thanks for the report. You would be welcome to contribute elsewhere in this repo, if that might be interesting to you. (There are many issues labeled up for grabs, and some marked easy.)