Skip to content

Duplicate assembly macros #64253

@am11

Description

@am11

In CoreRT, we copied a few assembly macros from CoreCLR repo. Those macros were later modified in coreclr then in runtime repos. Now that NativeAOT and PAL code exist in the same repo, is it feasible to deduplicate that code?

/runtime $ git ls-files ':/src/coreclr/pal/*unixasmmacros*.inc'
src/coreclr/pal/inc/unixasmmacros.inc
src/coreclr/pal/inc/unixasmmacrosamd64.inc
src/coreclr/pal/inc/unixasmmacrosarm.inc
src/coreclr/pal/inc/unixasmmacrosarm64.inc
src/coreclr/pal/inc/unixasmmacross390x.inc
src/coreclr/pal/inc/unixasmmacrosx86.inc

# vs.

/runtime $ git ls-files ':/src/coreclr/nativeaot/*unixasmmacros*.inc'
src/coreclr/nativeaot/Runtime/unix/unixasmmacros.inc
src/coreclr/nativeaot/Runtime/unix/unixasmmacrosamd64.inc
src/coreclr/nativeaot/Runtime/unix/unixasmmacrosarm.inc
src/coreclr/nativeaot/Runtime/unix/unixasmmacrosarm64.inc
src/coreclr/nativeaot/Runtime/unix/unixasmmacrosx86.inc

cc @MichalStrehovsky, @jkotas, @janvorli

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Status

    No status

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions