ArrayMarshaller.cs file doesn't get included when a project sets DisableImplicitAssemblyReferences to false but depends on System.Memory

[ViktorHofer]

Repro:

1. Add <DisableImplicitAssemblyReferences>false</DisableImplicitAssemblyReferences> to the Odbc.csproj
2. Remove the <Reference Include="..." /> statements at the bottom of the project file.
3. Run the following: .\dotnet.cmd build src\libraries\System.Data.Odbc\src\System.Data.Odbc.csproj /bl -f net7.0-windows

Error:

C:\git\runtime5\src\libraries\Common\src\Interop\Interop.Odbc.cs(172,34): error SYSLIB1051: The type 'byte[]' is not supported by source-generated P/Invokes. The generated source will not handle marshalling of parameter 'Value'. [C:\git\runtime5\src\libraries\System.Data.Odbc\src\System.Data.Odbc.csproj]
C:\git\runtime5\src\libraries\Common\src\Interop\Interop.Odbc.cs(199,35): error SYSLIB1051: The type 'char[]' is not supported by source-generated P/Invokes. The generated source will not handle marshalling of parameter 'rchState'. [C:\git\runtime5\src\libraries\System.Data.Odbc\src\System.Data.Odbc.csproj]
C:\git\runtime5\src\libraries\Common\src\Interop\Interop.Odbc.cs(201,35): error SYSLIB1051: The type 'char[]' is not supported by source-generated P/Invokes. The generated source will not handle marshalling of parameter 'MessageText'. [C:\git\runtime5\src\libraries\System.Data.Odbc\src\System.Data.Odbc.csproj]
C:\git\runtime5\src\libraries\Common\src\Interop\Interop.Odbc.cs(211,35): error SYSLIB1051: The type 'char[]' is not supported by source-generated P/Invokes. The generated source will not handle marshalling of parameter 'rchState'. [C:\git\runtime5\src\libraries\System.Data.Odbc\src\System.Data.Odbc.csproj]
C:\git\runtime5\src\libraries\Common\src\Interop\Interop.Odbc.cs(225,34): error SYSLIB1051: The type 'byte[]' is not supported by source-generated P/Invokes. The generated source will not handle marshalling of parameter 'rgbInfoValue'. [C:\git\runtime5\src\libraries\System.Data.Odbc\src\System.Data.Odbc.csproj]
C:\git\runtime5\src\libraries\Common\src\Interop\Interop.Odbc.cs(233,34): error SYSLIB1051: The type 'byte[]' is not supported by source-generated P/Invokes. The generated source will not handle marshalling of parameter 'rgbInfoValue'. [C:\git\runtime5\src\libraries\System.Data.Odbc\src\System.Data.Odbc.csproj]

Workaround: Set EnableLibraryImportGenerator to true.

cc @jkoritzinsky

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[ViktorHofer]

Affects System.Diagnostics.EventLog as well:

C:\git\runtime5\src\libraries\System.Diagnostics.EventLog\src\System\Diagnostics\Reader\UnsafeNativeMethods.cs(467,73): error SYSLIB1051: The type 'System.IntPtr[]' is not supported by source-generated P/Invokes. The generated source will not handle marshalling of parameter 'events'. [C:\git\runtime5\src\libraries\System.Diagnostics.EventLog\src\System.Diagnostics.EventLog.csproj]
C:\git\runtime5\src\libraries\System.Diagnostics.EventLog\src\System\Diagnostics\Reader\UnsafeNativeMethods.cs(569,43): error SYSLIB1051: The type 'char[]' is not supported by source-generated P/Invokes. The generated source will not handle marshalling of parameter 'channelPathBuffer'. [C:\git\runtime5\src\libraries\System.Diagnostics.EventLog\src\System.Diagnostics.EventLog.csproj]
C:\git\runtime5\src\libraries\System.Diagnostics.EventLog\src\System\Diagnostics\Reader\UnsafeNativeMethods.cs(582,43): error SYSLIB1051: The type 'char[]' is not supported by source-generated P/Invokes. The generated source will not handle marshalling of parameter 'publisherIdBuffer'. [C:\git\runtime5\src\libraries\System.Diagnostics.EventLog\src\System.Diagnostics.EventLog.csproj]
C:\git\runtime5\src\libraries\System.Diagnostics.EventLog\src\System\Diagnostics\Reader\UnsafeNativeMethods.cs(664,42): error SYSLIB1051: The type 'string[]' is not supported by source-generated P/Invokes. The generated source will not handle marshalling of parameter 'valuePaths'. [C:\git\runtime5\src\libraries\System.Diagnostics.EventLog\src\System.Diagnostics.EventLog.csproj]
C:\git\runtime5\src\libraries\System.Diagnostics.EventLog\src\System\Diagnostics\Reader\UnsafeNativeMethods.cs(674,43): error SYSLIB1051: The type 'char[]' is not supported by source-generated P/Invokes. The generated source will not handle marshalling of parameter 'buffer'. [C:\git\runtime5\src\libraries\System.Diagnostics.EventLog\src\System.Diagnostics.EventLog.csproj]
C:\git\runtime5\src\libraries\System.Diagnostics.EventLog\src\System\Diagnostics\Reader\UnsafeNativeMethods.cs(746,49): error SYSLIB1051: The type 'Microsoft.Win32.UnsafeNativeMethods.EvtStringVariant[]' is not supported by source-generated P/Invokes. The generated source will not handle marshalling of parameter 'values'. [C:\git\runtime5\src\libraries\System.Diagnostics.EventLog\src\System.Diagnostics.EventLog.csproj]
C:\git\runtime5\src\libraries\System.Diagnostics.EventLog\src\System\Diagnostics\Reader\UnsafeNativeMethods.cs(749,44): error SYSLIB1051: The type 'char[]' is not supported by source-generated P/Invokes. The generated source will not handle marshalling of parameter 'buffer'. [C:\git\runtime5\src\libraries\System.Diagnostics.EventLog\src\System.Diagnostics.EventLog.csproj]
C:\git\runtime5\src\libraries\Common\src\Interop\Windows\Advapi32\Interop.LookupAccountSid.cs(14,20): error SYSLIB1051: The type 'byte[]' is not supported by source-generated P/Invokes. The generated source will not handle marshalling of parameter 'Sid'. [C:\git\runtime5\src\libraries\System.Diagnostics.EventLog\src\System.Diagnostics.EventLog.csproj]
C:\git\runtime5\src\libraries\Common\src\Interop\Windows\Advapi32\Interop.ReadEventLog.cs(21,20): error SYSLIB1051: The type 'byte[]' is not supported by source-generated P/Invokes. The generated source will not handle marshalling of parameter 'lpBuffer'. [C:\git\runtime5\src\libraries\System.Diagnostics.EventLog\src\System.Diagnostics.EventLog.csproj]
C:\git\runtime5\src\libraries\Common\src\Interop\Windows\Advapi32\Interop.ReportEvent.cs(19,20): error SYSLIB1051: The type 'byte[]' is not supported by source-generated P/Invokes. The generated source will not handle marshalling of parameter 'lpUserSid'. [C:\git\runtime5\src\libraries\System.Diagnostics.EventLog\src\System.Diagnostics.EventLog.csproj]
C:\git\runtime5\src\libraries\Common\src\Interop\Windows\Advapi32\Interop.ReportEvent.cs(23,20): error SYSLIB1051: The type 'byte[]' is not supported by source-generated P/Invokes. The generated source will not handle marshalling of parameter 'lpRawData'. [C:\git\runtime5\src\libraries\System.Diagnostics.EventLog\src\System.Diagnostics.EventLog.csproj]
C:\git\runtime5\src\libraries\Common\src\Interop\Windows\Kernel32\Interop.FormatMessage_SafeLibraryHandle.cs(22,26): error SYSLIB1051: The type 'char[]' is not supported by source-generated P/Invokes. The generated source will not handle marshalling of parameter 'lpBuffer'. [C:\git\runtime5\src\libraries\System.Diagnostics.EventLog\src\System.Diagnostics.EventLog.csproj]
C:\git\runtime5\src\libraries\Common\src\Interop\Windows\Kernel32\Interop.FormatMessage_SafeLibraryHandle.cs(24,22): error SYSLIB1051: The type 'System.IntPtr[]' is not supported by source-generated P/Invokes. The generated source will not handle marshalling of parameter 'arguments'. [C:\git\runtime5\src\libraries\System.Diagnostics.EventLog\src\System.Diagnostics.EventLog.csproj]

And DirectoryServices* projects

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Repro:

1. Add <DisableImplicitAssemblyReferences>false</DisableImplicitAssemblyReferences> to the Odbc.csproj
2. Remove the <Reference Include="..." /> statements at the bottom of the project file.
3. Run the following: .\dotnet.cmd build src\libraries\System.Data.Odbc\src\System.Data.Odbc.csproj /bl -f net7.0-windows

Error:

C:\git\runtime5\src\libraries\Common\src\Interop\Interop.Odbc.cs(172,34): error SYSLIB1051: The type 'byte[]' is not supported by source-generated P/Invokes. The generated source will not handle marshalling of parameter 'Value'. [C:\git\runtime5\src\libraries\System.Data.Odbc\src\System.Data.Odbc.csproj]
C:\git\runtime5\src\libraries\Common\src\Interop\Interop.Odbc.cs(199,35): error SYSLIB1051: The type 'char[]' is not supported by source-generated P/Invokes. The generated source will not handle marshalling of parameter 'rchState'. [C:\git\runtime5\src\libraries\System.Data.Odbc\src\System.Data.Odbc.csproj]
C:\git\runtime5\src\libraries\Common\src\Interop\Interop.Odbc.cs(201,35): error SYSLIB1051: The type 'char[]' is not supported by source-generated P/Invokes. The generated source will not handle marshalling of parameter 'MessageText'. [C:\git\runtime5\src\libraries\System.Data.Odbc\src\System.Data.Odbc.csproj]
C:\git\runtime5\src\libraries\Common\src\Interop\Interop.Odbc.cs(211,35): error SYSLIB1051: The type 'char[]' is not supported by source-generated P/Invokes. The generated source will not handle marshalling of parameter 'rchState'. [C:\git\runtime5\src\libraries\System.Data.Odbc\src\System.Data.Odbc.csproj]
C:\git\runtime5\src\libraries\Common\src\Interop\Interop.Odbc.cs(225,34): error SYSLIB1051: The type 'byte[]' is not supported by source-generated P/Invokes. The generated source will not handle marshalling of parameter 'rgbInfoValue'. [C:\git\runtime5\src\libraries\System.Data.Odbc\src\System.Data.Odbc.csproj]
C:\git\runtime5\src\libraries\Common\src\Interop\Interop.Odbc.cs(233,34): error SYSLIB1051: The type 'byte[]' is not supported by source-generated P/Invokes. The generated source will not handle marshalling of parameter 'rgbInfoValue'. [C:\git\runtime5\src\libraries\System.Data.Odbc\src\System.Data.Odbc.csproj]

Workaround: Set EnableLibraryImportGenerator to true.

cc @jkoritzinsky

Author:	ViktorHofer
Assignees:	-
Labels:	area-Infrastructure-libraries, untriaged
Milestone:	-

[ViktorHofer]

@am11 unsure if that's actually infra libraries, depends on who owns the generators.targets file. I think area-Infrastructure would be better in this case :)

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Repro:

1. Add <DisableImplicitAssemblyReferences>false</DisableImplicitAssemblyReferences> to the Odbc.csproj
2. Remove the <Reference Include="..." /> statements at the bottom of the project file.
3. Run the following: .\dotnet.cmd build src\libraries\System.Data.Odbc\src\System.Data.Odbc.csproj /bl -f net7.0-windows

Error:

C:\git\runtime5\src\libraries\Common\src\Interop\Interop.Odbc.cs(172,34): error SYSLIB1051: The type 'byte[]' is not supported by source-generated P/Invokes. The generated source will not handle marshalling of parameter 'Value'. [C:\git\runtime5\src\libraries\System.Data.Odbc\src\System.Data.Odbc.csproj]
C:\git\runtime5\src\libraries\Common\src\Interop\Interop.Odbc.cs(199,35): error SYSLIB1051: The type 'char[]' is not supported by source-generated P/Invokes. The generated source will not handle marshalling of parameter 'rchState'. [C:\git\runtime5\src\libraries\System.Data.Odbc\src\System.Data.Odbc.csproj]
C:\git\runtime5\src\libraries\Common\src\Interop\Interop.Odbc.cs(201,35): error SYSLIB1051: The type 'char[]' is not supported by source-generated P/Invokes. The generated source will not handle marshalling of parameter 'MessageText'. [C:\git\runtime5\src\libraries\System.Data.Odbc\src\System.Data.Odbc.csproj]
C:\git\runtime5\src\libraries\Common\src\Interop\Interop.Odbc.cs(211,35): error SYSLIB1051: The type 'char[]' is not supported by source-generated P/Invokes. The generated source will not handle marshalling of parameter 'rchState'. [C:\git\runtime5\src\libraries\System.Data.Odbc\src\System.Data.Odbc.csproj]
C:\git\runtime5\src\libraries\Common\src\Interop\Interop.Odbc.cs(225,34): error SYSLIB1051: The type 'byte[]' is not supported by source-generated P/Invokes. The generated source will not handle marshalling of parameter 'rgbInfoValue'. [C:\git\runtime5\src\libraries\System.Data.Odbc\src\System.Data.Odbc.csproj]
C:\git\runtime5\src\libraries\Common\src\Interop\Interop.Odbc.cs(233,34): error SYSLIB1051: The type 'byte[]' is not supported by source-generated P/Invokes. The generated source will not handle marshalling of parameter 'rgbInfoValue'. [C:\git\runtime5\src\libraries\System.Data.Odbc\src\System.Data.Odbc.csproj]

Workaround: Set EnableLibraryImportGenerator to true.

cc @jkoritzinsky

Author:	ViktorHofer
Assignees:	-
Labels:	area-Infrastructure, untriaged
Milestone:	-