JIT: Assertion failed '!call->IsExpRuntimeLookup()' during 'Lowering nodeinfo'

[jakobbotsch]

JIT\Regression\JitBlue\DevDiv_461649 fails on win-x86 with the STRESS_BB_PROFILES mode enabled.

$env:DOTNET_TieredCompilation=0
$env:DOTNET_JitStressModeNames="STRESS_BB_PROFILES"

BEGIN EXECUTION
 "C:\dev\dotnet\runtime2\artifacts\tests\coreclr\windows.x86.Checked\Tests\Core_Root\corerun.exe" -p "System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true"  DevDiv_461649.dll

Assert failure(PID 18988 [0x00004a2c], Thread: 29108 [0x71b4]): Assertion failed '!call->IsExpRuntimeLookup()' in 'System.Xml.Xsl.XPath.XPathParser`1[System.__Canon]:Parse(System.Xml.Xsl.XPath.XPathScanner,System.Xml.Xsl.XPath.IXPathBuilder`1[System.__Canon],int):System.__Canon:this' during 'Lowering nodeinfo' (IL size 107; hash 0x83d355ca; FullOpts)

    File: C:\dev\dotnet\runtime2\src\coreclr\jit\lower.cpp Line: 2113
    Image: C:\dev\dotnet\runtime2\artifacts\tests\coreclr\windows.x86.Checked\Tests\Core_Root\corerun.exe

Expected: 100
Actual: -1073740286
END EXECUTION - FAILED
FAILED

jit dump attached. cc @dotnet/jit-contrib @EgorBo

out.txt

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

---

JIT\Regression\JitBlue\DevDiv_461649 fails on win-x86 with the STRESS_BB_PROFILES mode enabled.

$env:DOTNET_TieredCompilation=0
$env:DOTNET_JitStressModeNames="STRESS_BB_PROFILES"

BEGIN EXECUTION
 "C:\dev\dotnet\runtime2\artifacts\tests\coreclr\windows.x86.Checked\Tests\Core_Root\corerun.exe" -p "System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true"  DevDiv_461649.dll

Assert failure(PID 18988 [0x00004a2c], Thread: 29108 [0x71b4]): Assertion failed '!call->IsExpRuntimeLookup()' in 'System.Xml.Xsl.XPath.XPathParser`1[System.__Canon]:Parse(System.Xml.Xsl.XPath.XPathScanner,System.Xml.Xsl.XPath.IXPathBuilder`1[System.__Canon],int):System.__Canon:this' during 'Lowering nodeinfo' (IL size 107; hash 0x83d355ca; FullOpts)

    File: C:\dev\dotnet\runtime2\src\coreclr\jit\lower.cpp Line: 2113
    Image: C:\dev\dotnet\runtime2\artifacts\tests\coreclr\windows.x86.Checked\Tests\Core_Root\corerun.exe

Expected: 100
Actual: -1073740286
END EXECUTION - FAILED
FAILED

jit dump attached. cc @dotnet/jit-contrib @EgorBo

out.txt

Author:	jakobbotsch
Assignees:	-
Labels:	area-CodeGen-coreclr
Milestone:	-

[EgorBo]

Broken in #82973 cc @kunalspathak

You moved expansions in general helpers but left

    if (opts.OptimizationEnabled())
    {
        fgReorderBlocks(/* useProfileData */ false);
        fgUpdateChangedFlowGraph(FlowGraphUpdates::COMPUTE_BASICS);
    }

part in fgExpandRuntimeLookupsForCall

and it re-shuffles blocks