Skip to content

Revisit the strategy for fail fasts from compInlineResult->NoteFatal. #8713

@sandreenko

Description

@sandreenko

We do not have handlers for compDonotInline after some functions, that do "NoteFatal". For example after lvaGrabTemp. It creates problem, if we do NoteFatal for the second time, it blows the assert that compilation should be already interrupted.
There are two obvious solutions:

  1. delete the assert and allow to continue execution with several "NoteFatal" before a handler;
  2. do fail-fast check after the each function, that can do "NoteFatal".

The first will waste time for the work, that will be thrown out.
The second will need new intrusive checks in many places.

Attach dotnet/coreclr#13271 .

category:correctness
theme:inlining
skill-level:expert
cost:medium

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIdesign-discussionOngoing discussion about design without consensusenhancementProduct code improvement that does NOT require public API changes/additions

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions