-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Open
Labels
area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMICLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIdesign-discussionOngoing discussion about design without consensusOngoing discussion about design without consensusenhancementProduct code improvement that does NOT require public API changes/additionsProduct code improvement that does NOT require public API changes/additions
Milestone
Description
We do not have handlers for compDonotInline after some functions, that do "NoteFatal". For example after lvaGrabTemp. It creates problem, if we do NoteFatal for the second time, it blows the assert that compilation should be already interrupted.
There are two obvious solutions:
- delete the assert and allow to continue execution with several "NoteFatal" before a handler;
- do fail-fast check after the each function, that can do "NoteFatal".
The first will waste time for the work, that will be thrown out.
The second will need new intrusive checks in many places.
Attach dotnet/coreclr#13271 .
category:correctness
theme:inlining
skill-level:expert
cost:medium
Metadata
Metadata
Assignees
Labels
area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMICLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIdesign-discussionOngoing discussion about design without consensusOngoing discussion about design without consensusenhancementProduct code improvement that does NOT require public API changes/additionsProduct code improvement that does NOT require public API changes/additions