[macOS] Build failure: __undef_min_max:17:2: error: : macro min is incompatible with C++. #undefing min [-Werror,-W#warnings]

[4creators]

Reproducible hitting the above error while trying to build freshly cloned coreclr repo.

Executing make install -j 5
Scanning dependencies of target tracepointprovider
Scanning dependencies of target System.Globalization.Native
Scanning dependencies of target System.Globalization.Native_Static
Scanning dependencies of target unixcoreruncommon
Scanning dependencies of target coreclrpal
[  0%] Building CXX object src/coreclr/hosts/unixcoreruncommon/CMakeFiles/unixcoreruncommon.dir/coreruncommon.cpp.o
[  0%] Building CXX object src/pal/src/CMakeFiles/tracepointprovider.dir/misc/tracepointprovider.cpp.o
[  0%] Building CXX object src/corefx/System.Globalization.Native/CMakeFiles/System.Globalization.Native.dir/calendarData.cpp.o
[  0%] Building CXX object src/corefx/System.Globalization.Native/CMakeFiles/System.Globalization.Native_Static.dir/calendarData.cpp.o
In file included from /Users/uw/src/coreclr/src/pal/src/misc/tracepointprovider.cpp:19:
In file included from /Users/uw/src/coreclr/src/pal/src/include/pal/palinternal.h:591:
In file included from /System/Library/Frameworks/CoreServices.framework/Headers/CoreServices.h:19:
In file included from /System/Library/Frameworks/CoreFoundation.framework/Headers/CoreFoundation.h:24:
In file included from /Library/Developer/CommandLineTools/usr/include/c++/v1/math.h:310:
In file included from /Library/Developer/CommandLineTools/usr/include/c++/v1/limits:112:
/Library/Developer/CommandLineTools/usr/include/c++/v1/__undef_min_max:17:2: error: : macro min is incompatible with C++. #undefing min [-Werror,-W#warnings]
#warning: macro min is incompatible with C++.  #undefing min
 ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/__undef_min_max:29:2: error: : macro max is incompatible with C++. #undefing max [-Werror,-W#warnings]
#warning: macro max is incompatible with C++.  #undefing max
 ^
[  0%] Building CXX object src/pal/src/CMakeFiles/coreclrpal.dir/cruntime/file.cpp.o
In file included from /Users/uw/src/coreclr/src/pal/src/cruntime/file.cpp:22:
In file included from /Users/uw/src/coreclr/src/pal/src/include/pal/palinternal.h:591:
In file included from /System/Library/Frameworks/CoreServices.framework/Headers/CoreServices.h:19:
In file included from /System/Library/Frameworks/CoreFoundation.framework/Headers/CoreFoundation.h:24:
In file included from /Library/Developer/CommandLineTools/usr/include/c++/v1/math.h:310:
In file included from /Library/Developer/CommandLineTools/usr/include/c++/v1/limits:112:
/Library/Developer/CommandLineTools/usr/include/c++/v1/__undef_min_max:17:2: error: : macro min is incompatible with C++. #undefing min [-Werror,-W#warnings]
#warning: macro min is incompatible with C++.  #undefing min
 ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/__undef_min_max:29:2: error: : macro max is incompatible with C++. #undefing max [-Werror,-W#warnings]
#warning: macro max is incompatible with C++.  #undefing max
 ^
2 errors generated.
make[2]: *** [src/pal/src/CMakeFiles/tracepointprovider.dir/misc/tracepointprovider.cpp.o] Error 1
make[1]: *** [src/pal/src/CMakeFiles/tracepointprovider.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

System configuration:

  System Version:	macOS 10.12.6 (16G29)
  Kernel Version:	Darwin 16.7.0
  Boot Volume:	Macintosh HD
  Boot Mode:	Normal
  Computer Name:	MacBook Air (Admin)
  Xcode Version:      Version 8.3.2 (8E2002)

repo commit: c90a41b

[janvorli]

I can repro this issue after upgrading to Xcode 9 (I was not hitting it with any previous Xcode version). There are actually many more failures hidden behind this one (after fixing this, other ones related to C++ headers start popping out). I am working on a fix.

[4creators]

@janvorli Thanks!