Skip to content

FixOptRepeat without ParseArrayAddress fix #100353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BruceForstall wants to merge 2 commits into from
Closed

FixOptRepeat without ParseArrayAddress fix #100353

BruceForstall wants to merge 2 commits into from

Conversation

@BruceForstall
Copy link
Contributor

@BruceForstall BruceForstall commented Mar 27, 2024

#94250
without
#100327

@BruceForstall BruceForstall added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Mar 27, 2024
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 27, 2024
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Mar 27, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@BruceForstall
Copy link
Contributor Author

BruceForstall commented Mar 27, 2024

/azp run runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 27, 2024

Azure Pipelines successfully started running 3 pipeline(s).

@BruceForstall BruceForstall added the NO-REVIEW Experimental/testing PR, do NOT review it label Mar 27, 2024
@build-analysis build-analysis bot mentioned this pull request Mar 27, 2024
Open
3 tasks
@BruceForstall
Fix JitOptRepeat
0dfe56a 
1. Remove an assertion checking assert that can be invalid under JitOptRepeat, where we might
lose information that a constant was ever a handle.
2. Fix parsing of GT_ARR_ADDR trees during VN. After optimizations, they might not be
recognizable.
3. Disable JIT/Directed/debugging/debuginfo/tester.csproj under OptRepeat: optimizations
mess with its debug info expectations.
@BruceForstall
FixOptRepeat without ParseArrayAddress fix
635912e 
dotnet#94250
without
dotnet#100327
@BruceForstall BruceForstall force-pushed the FixOptRepeatWithoutParseArrayAddressFix branch from 27a5afd to 635912e Compare March 29, 2024 17:03
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@BruceForstall BruceForstall

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@BruceForstall