[release/8.0-staging] JIT: Fixed incorrect reversed condition for GT#100372
Merged
AndyAyersMS merged 6 commits intorelease/8.0-stagingfrom Apr 15, 2024
Merged
Conversation
ghost
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
This was referenced Mar 28, 2024
kunalspathak
added
the
Servicing-consider
Contributor
|
@dotnet/jit-contrib |
AndyAyersMS
approved these changes
Mar 28, 2024
Member
|
@kunalspathak I would have classified this as low risk, we have had the fix in 9.0 for a while and it has not led to further issues. |
jeffschwMSFT
approved these changes
Mar 28, 2024
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. we will take for consideration in 8.0.x
rbhanda
added
Servicing-approved
Member
|
@jeffschwMSFT @AndyAyersMS @TIHan - please assess failures and merge today. |
Member
|
Build/test logs are gone, so will need to rerun. |
Member
|
going to bounce this as all the assets are gone too. |
Contributor
|
Looking good, @AndyAyersMS |
Member
|
Yep. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #92316 to release/8.0-staging
/cc @kunalspathak @TIHan
Customer Impact
This was reported by a customer in #99954, where they were having a wrong functional behavior from a simple condition evaluation
a <= bshould have been evaluated totruebut was evaluating tofalse, leading to having their code take different code path. In the example that customer provided, they were seeing an exception was thrown because of the issue and the correct behavior was that no exception should have been thrown. The circumstances for it to occur is rare though and would trigger under very specific conditions. Thefalseblock (the code follows theelseshould have been optimized in prior phases and should be empty when we were trying to optimize the code in question) and there are some other requirements like what type of blocks they jump to in order the problematic code path to get triggered.Regression
The code has been there since
dotnet/coreclrdays and was introduced back in dotnet/coreclr#17733, but we recently saw it getting exposed.Testing
The fix was verified on the customer provided example in #99954. The code has been there for a while and was not discovered until September 2023 when we found out and fixed it in .NET 9. However, we didn't back-ported to .NET 8 back then. The backport also adds a test case for this scenario.
Risk
Low: This is a rare scenario and we had it .NET 9 for a while without causing any problem.