Exclude unhandledTester test on native AOT #100574
Merged
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is unfortunate because it was added for native AOT sake in dotnet#91415. Then Tomas rewrote the test to execute corerun.exe in dotnet#91560 making it 100% unsupportable with native AOT. What the test is doing doesn't look supportable with the merged runner infra and runs into the same issues I saw in dotnet#100269. We never noticed this test is broken because tests requiring process isolation are completely busted with native AOT. I did a local run and started re-baselining again because this is not the only regression.
ghost
added
the
needs-area-label
jkoritzinsky
approved these changes
Apr 6, 2024
am11
added
area-NativeAOT-coreclr
and removed
needs-area-label
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
This is unfortunate because it was added for native AOT sake in dotnet#91415. Then Tomas rewrote the test to execute corerun.exe in dotnet#91560 making it 100% unsupportable with native AOT. What the test is doing doesn't look supportable with the merged runner infra and runs into the same issues I saw in dotnet#100269. We never noticed this test is broken because tests requiring process isolation are completely busted with native AOT. I did a local run and started re-baselining again because this is not the only regression.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is unfortunate because it was added for native AOT sake in #91415.
Then Tomas rewrote the test to execute corerun.exe in #91560 making it 100% unsupportable with native AOT.
What the test is doing doesn't look supportable with the merged runner infra and runs into the same issues I saw in #100269, I assume that's why Tomas took the easy way out by using corerun. Then we conveniently didn't detect it's broken because process isolation testing is busted with native AOT (found this regression in my local re-baselining run. it's not the only regression)