Skip to content

[browser][MT] fix thread creation race with finalizer#100778

Merged
pavelsavara merged 1 commit intodotnet:mainfrom
pavelsavara:browser_mt_fix_worker_preload
Apr 9, 2024
Merged

[browser][MT] fix thread creation race with finalizer#100778
pavelsavara merged 1 commit intodotnet:mainfrom
pavelsavara:browser_mt_fix_worker_preload

Conversation

@pavelsavara
Copy link
Member

  • initialize mono_wasm_init_finalizer_thread immediately during startup, not lazily
  • make loaderHelpers.loadingWorkers Promise
  • new FinalizerWorks test
  • drop finalizerThreadStartDelayMs
  • drop is_thread_available
  • fix browser-threads sample

…p, not lazily

- make loaderHelpers.loadingWorkers Promise
- FinalizerWorks test
- drop finalizerThreadStartDelayMs
- drop is_thread_available
- fix browser-threads sample
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-VM-threading-mono os-browser Browser variant of arch-wasm labels Apr 8, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Apr 8, 2024
@pavelsavara pavelsavara self-assigned this Apr 8, 2024
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@pavelsavara
Copy link
Member Author

/ba-g failures are
#99609
#100275
#100757

@pavelsavara pavelsavara merged commit 4c9db8a into dotnet:main Apr 9, 2024
@pavelsavara pavelsavara deleted the browser_mt_fix_worker_preload branch April 9, 2024 10:45
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-VM-threading-mono os-browser Browser variant of arch-wasm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants