Workaround for build failure in cdacreader when EmitCompilerGeneratedFiles=true#101279
Merged
akoeplinger merged 1 commit intodotnet:mainfrom Apr 19, 2024
Merged
Conversation
ghost
added
the
Contributor
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
This comment was marked as spam.
This comment was marked as spam.
This was referenced Apr 19, 2024
System.Net.Http.Functional.Tests.HttpMetricsTest_Http11_Async_HttpMessageInvoker Test failure
#96407
Closed
ViktorHofer
approved these changes
Apr 19, 2024
akoeplinger
approved these changes
Apr 19, 2024
Contributor
|
After this PR, there is an error during coreclr camke-config step by command #### linux-debian-AMD64 and loongarch64 are both failed !!!
./build-runtime.sh -debug -loongarch64 -nopgooptimize -skipmanaged
-- Looking for process_vm_readv
-- Looking for process_vm_readv - found
CMake Error at debug/runtimeinfo/CMakeLists.txt:57 (message):
No cdac-build-tool set or does not exist
-- Configuring incomplete, errors occurred!
See also "/home/qiao/work_qiao/runtime/artifacts/obj/coreclr/linux.loongarch64.Debug/CMakeFiles/CMakeOutput.log".
See also "/home/qiao/work_qiao/runtime/artifacts/obj/coreclr/linux.loongarch64.Debug/CMakeFiles/CMakeError.log".#100650 |
Member
Author
|
@shushanhf This PR is fixing a different problem (from before #100650 went in) and is unrelated to that error. @lambdageek's change in #101297 should be addressing that one. |
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
…tnet#101279) When we build `cdacreader`, we run the `LinkNative` target. This depends on `Compile` not `Build`, which means the `BuildOnlySettings` target that sets `BuildingProject=true` doesn't run. When `EmitCompilerGeneratedFiles=true`, this results in the generated output path not being created and the compiler erroring when trying to emit files to the path. See dotnet/roslyn#73075. CodeQL injects `-p:EmitCompilerGeneratedFiles=true` into the command line arguments. This was resulting in build failures in jobs where CodeQL is run. This change adds a workaround to our infrastructure for building NativeAOT-ed runtime components such that the generated output path is always created if `EmitCompilerGeneratedFiles=true`. Manually tested by explicitly passing that property on the command line. Fixes dotnet/source-build#4335
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we build
cdacreader, we run theLinkNativetarget. This depends onCompilenotBuild, which means theBuildOnlySettingstarget that setsBuildingProject=truedoesn't run. WhenEmitCompilerGeneratedFiles=true, this results in the generated output path not being created and the compiler erroring when trying to emit files to the path. See dotnet/roslyn#73075.CodeQL injects
-p:EmitCompilerGeneratedFiles=trueinto the command line arguments. This was resulting in build failures in jobs where CodeQL is run.This change adds a workaround to our infrastructure for building NativeAOT-ed runtime components such that the generated output path is always created if
EmitCompilerGeneratedFiles=true. Manually tested by explicitly passing that property on the command line.Fixes dotnet/source-build#4335