[release/8.0-staging] Sigsegv when calling a virtual method via UnsafeAccessorAttribute #101649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Contributor
|
Tagging subscribers to this area: @mangod9 |
jkotas
approved these changes
Apr 27, 2024
AaronRobinsonMSFT
added
the
Servicing-consider
jeffschwMSFT
approved these changes
Apr 28, 2024
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
lgtm. we will take for consideration in 8.0.x
jeffschwMSFT
changed the title
rbhanda
added
Servicing-approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #101648 to release/8.0-staging
/cc @AaronRobinsonMSFT
Customer Impact
Sigsegv when calling a virtual method via
UnsafeAccessorAttribute(repeatidly). This manifests when PGO kicks in.Regression
No. The
UnsafeAccessorAttributewas introduced in .NET 8.Testing
This was dead code removal.
Risk
Low.