[RISC-V] fix rm field in riscvd instruction#101908
Merged
jkotas merged 1 commit intodotnet:mainfrom May 6, 2024
Merged
Conversation
Changed rm from 1 to 0. Fixed instructions: - fcvt.d.w - fcvt.w.d - fcvt.d.wu - fcvt.wu.d - fcvt.d.s - fcvt.s.d
ghost
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
tomeksowi
approved these changes
May 6, 2024
Member
|
Nit: s/riscvd/fcvt in title :) |
yurai007
approved these changes
May 6, 2024
gbalykov
approved these changes
May 6, 2024
jkotas
approved these changes
May 6, 2024
Member
|
Congratulations on landing your first pull request! |
Member
|
Thank you and congratulations!!! 🎆 |
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
Changed rm from 1 to 0. Fixed instructions: - fcvt.d.w - fcvt.w.d - fcvt.d.wu - fcvt.wu.d - fcvt.d.s - fcvt.s.d
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
Changed rm from 1 to 0. Fixed instructions: - fcvt.d.w - fcvt.w.d - fcvt.d.wu - fcvt.wu.d - fcvt.d.s - fcvt.s.d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When i was working on #101683 I found that R2RDump prints
Decode Failurefor those instructions:, when i ran R2RDump e.g. for
System.Private.CoreLib.dll. I checked it is printed bylibcoredistoolsbecause LLVM MC cannot decode instructions properly. The problem is withrmfield. According to The RISC-V Instruction Set Manualand when i changed this field to 0 it fixed the problem. Below instructions also set
rmto 1I checked my changes running tests for coreclr with priority 1 and i didn't get any new error.
Part of #84834, cc @dotnet/samsung