JIT: Test RPO-based layout in libraries-pgo
#101924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Contributor
Author
|
/azp run runtime-coreclr libraries-pgo |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
I'm not expecting |
amanasifkhalid
added
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
Author
|
|
AndyAyersMS
approved these changes
May 6, 2024
Member
AndyAyersMS
left a comment
AndyAyersMS
left a comment
There was a problem hiding this comment.
Suggest leaving win arm64 off for now...
| extraHelixArguments: /maxcpucount:10 | ||
| scenarios: | ||
| - defaultpgo | ||
| - jitrpolayout |
Member
There was a problem hiding this comment.
We haven't historically stressed Windows arm64 since we've been short on CI resources, and codegen is similar to Linux arm64. So perhaps leave this part out?
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #101851. @AndyAyersMS PTAL, thank you!