[release/9.0-preview5] [wasm] Stop setting problematic runtime feature switches #102943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
needs-area-label
lewing
added
Servicing-consider
lewing
approved these changes
May 31, 2024
mmitche
approved these changes
Jun 3, 2024
javiercn
approved these changes
Jun 3, 2024
Member
|
I had prepared an email for tactics approval but waited as @eiriktsarpalis had some questions about the change. As product owners do you feel confident with this change and want me to send the email? Also asking because the change in main hasn't been merged in main and doesn't even require tactics approval. |
Member
|
Wouldn't this change result in size regression? |
lewing
added
Servicing-approved
Member
Yes, we don't expect it to be substantial and if it is we can address it after preview 5 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #102934 to release/9.0-preview5
The fix in #102876 was not enough to resolve the problem so we've decided to not set the problematic feature flag to enable p5 to ship
/cc @lewing
Customer Impact
Any project using using these runtime feature flags will not work with the latest System.Text.Json
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
[How was the fix verified? How was the issue missed previously? What tests were added?]
Risk
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.