Skip to content

JIT: Fix debug flowgraph check for un-compacted blocks#103904

Merged
amanasifkhalid merged 1 commit intodotnet:mainfrom
amanasifkhalid:fix-compaction-check
Jun 24, 2024
Merged

JIT: Fix debug flowgraph check for un-compacted blocks#103904
amanasifkhalid merged 1 commit intodotnet:mainfrom
amanasifkhalid:fix-compaction-check

Conversation

@amanasifkhalid
Copy link
Copy Markdown
Contributor

Fixes #103875. When checking for un-compacted blocks, make sure we don't assert for cases that were purposefully left un-compacted to avoid churning the flowgraph late in the JIT's phases.

cc @dotnet/jit-contrib, @AndyAyersMS PTAL. Thanks!

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 24, 2024
@amanasifkhalid
Copy link
Copy Markdown
Contributor Author

/azp run runtime-coreclr jitstress

@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@amanasifkhalid
Copy link
Copy Markdown
Contributor Author

x86 jitstress failure is a timeout in GC tests, all other jitstress failures are #103577.

@amanasifkhalid amanasifkhalid merged commit bed1751 into dotnet:main Jun 24, 2024
@amanasifkhalid amanasifkhalid deleted the fix-compaction-check branch June 24, 2024 19:30
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test failure: GC/LargeMemory/Regressions/largearraytest/largearraytest.sh

2 participants