Improve resiliency when rooting broken assemblies#103962
Merged
MichalStrehovsky merged 1 commit intodotnet:mainfrom Jun 26, 2024
Merged
Improve resiliency when rooting broken assemblies#103962MichalStrehovsky merged 1 commit intodotnet:mainfrom
MichalStrehovsky merged 1 commit intodotnet:mainfrom
Conversation
Do a couple more upfront checks to trigger exceptions when it's recoverable. Fixes dotnet#103843. We still eventually crash when generating debug information since we don't have fine grained tracking of what parts of the type we looked at. The user would need to drop debug info generation, or stop feeding us garbage.
ghost
added
the
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
jkotas
approved these changes
Jun 25, 2024
Open
3 tasks
Member
Author
|
/ba-g known timeouts on Linux legs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do a couple more upfront checks to trigger exceptions when it's recoverable. Fixes #103843.
We still eventually crash when generating debug information since we don't have fine grained tracking of what parts of the type we looked at. The user would need to drop debug info generation, or stop feeding the compiler garbage.
Cc @dotnet/ilc-contrib