Skip to content

Add RetryHelper to AIA test#104381

Merged
bartonjs merged 1 commit intodotnet:mainfrom
vcsjones:fix-104375
Jul 5, 2024
Merged

Add RetryHelper to AIA test#104381
bartonjs merged 1 commit intodotnet:mainfrom
vcsjones:fix-104375

Conversation

@vcsjones
Copy link
Copy Markdown
Member

@vcsjones vcsjones commented Jul 3, 2024

Fixes #104375

This test failed with:

 Assert.NotEqual() Failure: Values are equal
      Expected: Not False
      Actual:       False

Since it expected "not false" (true) that means the theory that failed was AiaResponseKind.Cert.

"Working" AIA can be flaky and depends on the whims of the OS chain builder and pressure on CI for timeouts. All other AIA tests use RetryHelper, but this one did not. So let's add it to this one, too.

@bartonjs bartonjs merged commit 06e0076 into dotnet:main Jul 5, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AiaAcceptsCertTypesAndIgnoresNonCertTypes test failure in CI

2 participants