Ignore type resolution failures when checking for attributes in StackTrace.ToString.
#104530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-reflection |
Member
|
I do not think we want to be catching exceptions in reflection to make it resilient against missing assemblies. It is very fragile path. For example, this fix would make unsealing an attribute potentially breaking change going forward. #104528 should be fixed by ignoring reflection failures in the stacktrace printing code. |
teo-tsirpanis
changed the title
StackTrace.ToString.
teo-tsirpanis
force-pushed
the
ca-ignore-resolver-failures
branch
from
3386509 to
6d27738
Compare
…m throwing. An `IsDefinedSafe` method was added that returns false if checking for the attribute throws, and other usages in the file were updated as well. This also allows us to remove a big try catch block.
teo-tsirpanis
force-pushed
the
ca-ignore-resolver-failures
branch
from
6d27738 to
2afa59f
Compare
Contributor
Author
Didn't think about this, thanks! I updated the PR as you suggested, and guarded another possible source of resolver failures. |
Member
|
Build breaks... |
This was referenced Jul 9, 2024
Contributor
Author
|
Fixed build failures. Current CI failures are seemingly unrelated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104528.
Similar to #48535, this PR makes
StackTrace.ToStringresilient to exceptions when performing some more custom attribute retrieving. We do this by introducing***Safeedition of reflection methods that perform the operation and return a negative result if an exception was thrown, and updating all uses ofIsDefinedandGetCustomAttributesin theStackTraceclass.