Don't dispose timers if we're in our UnhandledException handler.#104828
Closed
StephenMolloy wants to merge 2 commits intodotnet:release/8.0-stagingfrom
Closed
Don't dispose timers if we're in our UnhandledException handler.#104828StephenMolloy wants to merge 2 commits intodotnet:release/8.0-stagingfrom
StephenMolloy wants to merge 2 commits intodotnet:release/8.0-stagingfrom
Conversation
StephenMolloy
added
Servicing-consider
Contributor
|
@StephenMolloy This needs to target the release/8.0-staging branch, not the release/8.0 branch directly. Can you please make the change? Make sure the branch switch doesn't accidentally bring in unrelated commits. |
Contributor
|
Because this change affects an OOB package: You'll also have to follow these instructions to enable building the package: https://github.com/dotnet/runtime/blob/main/docs/project/library-servicing.md#check-if-a-package-is-generated OOB assemblies don't get built by default in servicing branches. |
StephenMolloy
force-pushed
the
bp8_64115_Memcache-UnhandledEx-Timer-Deadlock
branch
from
2e4661c to
43a164f
Compare
Contributor
carlossanlop
left a comment
carlossanlop
left a comment
There was a problem hiding this comment.
Thanks. OOB changes look good.
Member
Author
|
Closed in favor of #106221 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timer was updated in 5.0 to improve performance, but is prone to deadlocks when manipulated in an unhandled exception handler. Which MemoryCache does. And MemoryCache is probably more likely to witness unhandled exceptions like OOM than typical code.
Original Issue: #64115 (and #102666)
.Net 9.0 PR: #103937
System.Runtime.Caching is an OOB package that ships alongside the runtime.