Redact query from HttpTelemetry#104970
Merged
ManickaP merged 3 commits intodotnet:mainfrom Jul 17, 2024
Merged
Conversation
ghost
added
the
Member
Author
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MihaZupan
approved these changes
Jul 16, 2024
src/libraries/System.Net.Http/src/System/Net/Http/HttpTelemetry.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
CarnaViire
reviewed
Jul 16, 2024
Member
CarnaViire
left a comment
CarnaViire
left a comment
There was a problem hiding this comment.
There's also
Is there a reason why we're skipping it?
CarnaViire
reviewed
Jul 16, 2024
src/libraries/System.Net.Http/src/System/Net/Http/HttpTelemetry.cs
Outdated
Show resolved
Hide resolved
This was referenced Jul 16, 2024
Build failure: Static graph-based restore failed with exit code .* but did not log an error.
#103526
Closed
Open
Member
Author
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
antonfirsov
added
the
breaking-change
dotnet-policy-service
bot
added
the
needs-breaking-change-doc-created
Contributor
|
Added When you commit this breaking change:
Tagging @dotnet/compat for awareness of the breaking change. |
Member
|
Breaking change doc is created: dotnet/docs#42794 |
liveans
removed
the
needs-breaking-change-doc-created
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #103769
Redacts query string from the official HttpTelemetry (EventSource "System.Net.Http"). Uses the same opt out as distributed tracing (Activity) and
HttpClientFactorylogging. Doesn't touch private events (EventSource "Private.InternalDiagnostics.*").Fixes #74340
cc @CarnaViire