Skip to content

Conversation

@jozkee
Copy link
Member

@jozkee jozkee commented Aug 13, 2024

Fixes #102513

@jozkee jozkee requested review from ericstj and stephentoub August 13, 2024 18:20
@jozkee jozkee self-assigned this Aug 13, 2024
@ghost
Copy link

ghost commented Aug 13, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Aug 13, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@jozkee jozkee added this to the 9.0.0 milestone Aug 13, 2024
Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Be aware that this type of change often reveals cases where folks compile against newer references than they run against. Make sure you have an eye on codeflow in case anything like that breaks.

@jozkee jozkee merged commit 380898a into dotnet:main Aug 13, 2024
@jozkee jozkee deleted the memorymarshal-push-down branch August 13, 2024 22:05
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compiling against methods that accept params span with only System.Runtime reference produces compiler error

2 participants