Fix condition for adding package readmes#106590
Conversation
Fixes #106585 The EnableDefualtPackageReadmeFile property needs to be defined before packaging.targets is imported.
ghost
added
the
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10442768239 |
|
/backport to release/9.0-rc1 |
|
Started backporting to release/9.0-rc1: https://github.com/dotnet/runtime/actions/runs/10442943879 |
ViktorHofer
requested review from
lewing,
pavelsavara and
sbomer
as code owners
|
this is breaking the official build in the workload step https://dev.azure.com/dnceng/internal/_build/results?buildId=2518856&view=logs&j=7bf215f5-1c95-5bbd-4005-575fc2c46c79&t=88f8f928-3551-5dff-d5e2-be29d98ae725&l=1677 |
|
Ok, looking. Don't we build workloads in PRs? Here's the fix: https://github.com/dotnet/runtime/pull/106638/files |
Fixes the official build break. Regressed with #106590
We build the nugets that the sdk uses but we don't build the msis that VS uses in PRs |
* Update workloads.csproj Fixes the official build break. Regressed with #106590 * Update workloads.csproj
3 participants
Fixes #106585
Regressed with e9ffa8c
The EnableDefualtPackageReadmeFile property needs to be defined before packaging.targets is imported.
Thanks for the report @MSDN-WhiteKnight