[release/9.0] Emscripten version reference for RTM build#106881
[release/9.0] Emscripten version reference for RTM build#106881pavel-purma wants to merge 3 commits intodotnet:release/9.0from pavel-purma:fix/EmscriptenVersion
Conversation
ghost
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
eng/Versions.props
Outdated
| <MicrosoftNETWorkloadEmscriptenCurrentManifest90100TransportVersion>9.0.0-rc.2.24421.3</MicrosoftNETWorkloadEmscriptenCurrentManifest90100TransportVersion> | ||
| <MicrosoftNETRuntimeEmscriptenVersion>$(MicrosoftNETWorkloadEmscriptenCurrentManifest90100TransportVersion)</MicrosoftNETRuntimeEmscriptenVersion> | ||
| <MicrosoftNETWorkloadEmscriptenCurrentManifest90100Version>9.0.0-rc.2.24421.3</MicrosoftNETWorkloadEmscriptenCurrentManifest90100Version> | ||
| <MicrosoftNETRuntimeEmscriptenVersion>$(MicrosoftNETWorkloadEmscriptenCurrentManifest90100Version)</MicrosoftNETRuntimeEmscriptenVersion> |
There was a problem hiding this comment.
This is because there are references to the packages via stable versions?
There was a problem hiding this comment.
TransportVersion is coming from non-shipping dependency and that did not work when used for references with version defined by MicrosoftNETRuntimeEmscriptenVersion. I have added another dependency with shipping versioning (MicrosoftNETWorkloadEmscriptenCurrentManifest90100Version) and use that version as for further references of Emscripten.
There was a problem hiding this comment.
Was the source build version not sufficient?
teo-tsirpanis
added
area-Infrastructure
and removed
community-contribution
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
|
Today's the RC2 snap. There's a merge conflict and an open conversation. @pavel-purma can you please unblock the PR so we can get it merged? |
There was a problem hiding this comment.
This should no longer be needed (for rtm at least). See the discussion here dotnet/sdk#43554
The manifests change name when they go to rtm now, not when the versions and as a result the same name is calculated from the stable version and transport package version in rtm.
carlossanlop
left a comment
carlossanlop
left a comment
There was a problem hiding this comment.
@pavel-purma - Please retarget this PR to the release/9.0-staging branch.
You can retarget to that branch by clicking on the Edit button on the top right (next to the PR title) and choosing the release/9.0-staging branch from the dropdown. Important: Please make sure you don't bring any unrelated changes from the release/9.0 branch when retargeting to release/9.0-staging.
5 participants
Added reference to Microsoft.NET.Workload.Emscripten.Current.Manifest and use that version fro Emscripten packages for RTM build