Skip to content

Fix chrome update action is failing #107131

Merged
ilonatommy merged 3 commits intodotnet:mainfrom
ilonatommy:fix-107125
Sep 2, 2024
Merged

Fix chrome update action is failing #107131
ilonatommy merged 3 commits intodotnet:mainfrom
ilonatommy:fix-107125

Conversation

@ilonatommy
Copy link
Copy Markdown
Member

@ilonatommy ilonatommy commented Aug 29, 2024

Fix #107125.

  • We were not compiling the src/tasks/WasmBuildTasks/WasmBuildTasks.csproj project on make -C src/mono/wasm build-tasks that triggers command -> dotnet.sh build src/tasks/tasks.proj /p:Configuration=Release /p:KeepNativeSymbols=true

tasks.proj was recently cleaned up in #104226. Since then it was compiling only:

  installer.tasks -> /workspaces/runtime/artifacts/bin/installer.tasks/Release/net9.0/installer.tasks.dll
  Crossgen2Tasks -> /workspaces/runtime/artifacts/bin/Crossgen2Tasks/Release/net9.0/Crossgen2Tasks.dll
  Microsoft.Interop.SourceGeneration -> /workspaces/runtime/artifacts/bin/Microsoft.Interop.SourceGeneration/Release/netstandard2.0/Microsoft.Interop.SourceGeneration.dll
  DownlevelLibraryImportGenerator -> /workspaces/runtime/artifacts/bin/DownlevelLibraryImportGenerator/Release/netstandard2.0/Microsoft.Interop.LibraryImportGenerator.Downlevel.dll
  installer.tasks -> /workspaces/runtime/artifacts/bin/installer.tasks/Release/net472/installer.tasks.dll

In the updated form it is compiling:

 MonoAOTCompiler -> /workspaces/runtime/artifacts/bin/MonoAOTCompiler/Release/net9.0/MonoAOTCompiler.dll
  AppleAppBuilder -> /workspaces/runtime/artifacts/bin/AppleAppBuilder/Release/net9.0/AppleAppBuilder.dll
  MobileBuildTasks -> /workspaces/runtime/artifacts/bin/MobileBuildTasks/Release/net9.0/MobileBuildTasks.dll
  Microsoft.NET.WebAssembly.Webcil -> /workspaces/runtime/artifacts/bin/Microsoft.NET.WebAssembly.Webcil/Release/net9.0/Microsoft.NET.WebAssembly.Webcil.dll
  AndroidAppBuilder -> /workspaces/runtime/artifacts/bin/AndroidAppBuilder/Release/net9.0/AndroidAppBuilder.dll
  AndroidAppBuilder -> /workspaces/runtime/artifacts/bin/AndroidAppBuilder/Release/net9.0/publish/
  Microsoft.NET.Sdk.WebAssembly.Pack.Tasks -> /workspaces/runtime/artifacts/bin/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/Release/net9.0/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks.dll
  AssemblyStripper -> /workspaces/runtime/artifacts/bin/AssemblyStripper/Release/net9.0/AssemblyStripper.dll
  WasmAppBuilder -> /workspaces/runtime/artifacts/bin/WasmAppBuilder/Release/net9.0/WasmAppBuilder.dll
  TestExclusionListTasks -> /workspaces/runtime/artifacts/bin/TestExclusionListTasks/Release/net9.0/TestExclusionListTasks.dll
  Microsoft.Interop.SourceGeneration -> /workspaces/runtime/artifacts/bin/Microsoft.Interop.SourceGeneration/Release/netstandard2.0/Microsoft.Interop.SourceGeneration.dll
  WasmBuildTasks -> /workspaces/runtime/artifacts/bin/WasmBuildTasks/Release/net9.0/WasmBuildTasks.dll
  MonoTargetsTasks -> /workspaces/runtime/artifacts/bin/MonoTargetsTasks/Release/net9.0/MonoTargetsTasks.dll
  WasmBuildTasks -> /workspaces/runtime/artifacts/bin/WasmBuildTasks/Release/net9.0/publish/
  WorkloadBuildTasks -> /workspaces/runtime/artifacts/bin/WorkloadBuildTasks/Release/net9.0/WorkloadBuildTasks.dll
  Crossgen2Tasks -> /workspaces/runtime/artifacts/bin/Crossgen2Tasks/Release/net9.0/Crossgen2Tasks.dll
  installer.tasks -> /workspaces/runtime/artifacts/bin/installer.tasks/Release/net9.0/installer.tasks.dll
  DownlevelLibraryImportGenerator -> /workspaces/runtime/artifacts/bin/DownlevelLibraryImportGenerator/Release/netstandard2.0/Microsoft.Interop.LibraryImportGenerator.Downlevel.dll
  WorkloadBuildTasks -> /workspaces/runtime/artifacts/bin/WorkloadBuildTasks/Release/net8.0/WorkloadBuildTasks.dll
  LibraryBuilder -> /workspaces/runtime/artifacts/bin/LibraryBuilder/Release/net9.0/LibraryBuilder.dll
  MonoAOTCompiler -> /workspaces/runtime/artifacts/bin/MonoAOTCompiler/Release/net472/MonoAOTCompiler.dll
  installer.tasks -> /workspaces/runtime/artifacts/bin/installer.tasks/Release/net472/installer.tasks.dll
  MobileBuildTasks -> /workspaces/runtime/artifacts/bin/MobileBuildTasks/Release/net472/MobileBuildTasks.dll
  AssemblyStripper -> /workspaces/runtime/artifacts/bin/AssemblyStripper/Release/net472/AssemblyStripper.dll
  LibraryBuilder -> /workspaces/runtime/artifacts/bin/LibraryBuilder/Release/net472/LibraryBuilder.dll
  Microsoft.NET.WebAssembly.Webcil -> /workspaces/runtime/artifacts/bin/Microsoft.NET.WebAssembly.Webcil/Release/net472/Microsoft.NET.WebAssembly.Webcil.dll
  MonoTargetsTasks -> /workspaces/runtime/artifacts/bin/MonoTargetsTasks/Release/net472/MonoTargetsTasks.dll
  Microsoft.NET.Sdk.WebAssembly.Pack.Tasks -> /workspaces/runtime/artifacts/bin/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/Release/net472/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks.dll
  WasmAppBuilder -> /workspaces/runtime/artifacts/bin/WasmAppBuilder/Release/net472/WasmAppBuilder.dll

So that we won't wait for the bot's PR, I added the update to the versions in this PR as well.
The version update will be done in a separate PR.

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Build-mono labels Aug 29, 2024
@ilonatommy ilonatommy self-assigned this Aug 29, 2024
@ilonatommy
Copy link
Copy Markdown
Member Author

Timeouts on Windows might be connected. Checking...

@ilonatommy
Copy link
Copy Markdown
Member Author

Let's separate the bump and the fix, I cannot find a reason for timeouts on Window's lanes other than the bump.

@ilonatommy
Copy link
Copy Markdown
Member Author

/ba-g the changes are not related to threading lib tests

@ilonatommy ilonatommy merged commit 3f103db into dotnet:main Sep 2, 2024
jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Sep 17, 2024
sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-Build-mono

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chrome update action is failing

2 participants