Fix chrome update action is failing #107131
Merged
ilonatommy merged 3 commits intodotnet:mainfrom Sep 2, 2024
Merged
Conversation
akoeplinger
approved these changes
Aug 29, 2024
Member
Author
|
Timeouts on Windows might be connected. Checking... |
This was referenced Aug 29, 2024
Closed
Open
Member
Author
|
Let's separate the bump and the fix, I cannot find a reason for timeouts on Window's lanes other than the bump. |
Member
Author
|
/ba-g the changes are not related to threading lib tests |
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
* Fix the error in action.
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
* Fix the error in action.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #107125.
src/tasks/WasmBuildTasks/WasmBuildTasks.csprojproject onmake -C src/mono/wasm build-tasksthat triggers command ->dotnet.sh build src/tasks/tasks.proj /p:Configuration=Release /p:KeepNativeSymbols=truetasks.projwas recently cleaned up in #104226. Since then it was compiling only:In the updated form it is compiling:
So that we won't wait for the bot's PR, I added the update to the versions in this PR as well.The version update will be done in a separate PR.