[release/9.0] Arm64/Sve: Remove entries of SVE APIs take 32-bit address #107780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
Note regarding the |
1 similar comment
|
Note regarding the |
kunalspathak
added
Servicing-consider
kunalspathak
requested review from
BrzVlad,
MichalStrehovsky,
akoeplinger,
fanyang-mono,
ilonatommy,
kg,
kotlarmilos,
lambdageek,
lewing,
maraf,
marek-safar,
pavelsavara,
sbomer,
steveisok and
thaystg
as code owners
Contributor
Author
|
Something is off with my branch. |
) * Remove entry of APIs because of dotnet#103297 * comment out the test cases for unsupported APIs
Contributor
Author
fixed the base to |
ilonatommy
approved these changes
Sep 13, 2024
kunalspathak
force-pushed
the
backport_107758
branch
from
913470d to
c8806ba
Compare
jeffschwMSFT
approved these changes
Sep 13, 2024
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved.
please file a breaking change between RC1 and RC2 for these removals. (even though this is a preview feature)
we can merge when ready
amanasifkhalid
approved these changes
Sep 13, 2024
kunalspathak
added
breaking-change
Contributor
|
Added When you commit this breaking change:
Tagging @dotnet/compat for awareness of the breaking change. |
3 tasks
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #107758 to release/9.0
Customer Impact
We have disabled several APIs that takes 32-bit address as input parameter because of lack of testing of such address. However, there were few APIs that were not disabled. This PR disables such APIs, until we add relevant test coverage in future release.
Regression
This is not a regression, but merely something that was not disabled.
Testing
The build works and all the tests that were using the APIs are commented out.
Risk
Low. This only affects SVE APIs that were enabled in earlier previews but are disabled because they are untested. Besides, SVE is an experimental feature for .NET 9.