-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Fix GC stress log and analysis #108655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GC stress log and analysis #108655
Conversation
…s 64-bit floating point values)
df9e20d to
018d47c
Compare
|
"ILC: error IL1013: Error processing 'name'" is #108031 |
Maoni0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than the few minor changes you took notes of, the rest LGTM!
|
@Maoni0, is this good to merge or there are some changes still needed? |
|
I see the typos in the 2 comments in gcpriv.h were still not fixed...
|
|
Ok, thanks. @mrsharm, can you please look into merging this PR (looks like some conflicts need to be resolved and the comments updated per Maoni above). Thx! |
|
@mrsharm You've added back the native version of the StressLogAnalyzer. Can you apply the changes that were in conflict to the managed implementation and delete the native implementation? In particular the changes to the recognition of GCStart messages |
|
Thanks for catching that, @jkoritzinsky! Removed the old files and updated the comment. And checked the build. Do let me know if any other changes are needed. |
Summary: This includes multiple fixes to reenable the viewing of GC stress log events (from GC dprintf) in StressLogAnalyzer. It makes a small subset of the events available in all _DEBUG builds, which provides a build check in CI without overwhelming the stress log or runtime. This includes an audit of dprintf(1, ...) sites. More detailed GC stress logs can be enabled by changing the sources (as before).
Fixes to StressLogAnalyzer are least-effort because it is intended to be replaced by a C# version in #104999.
Details:
gcDetailedStartMsggcDetailedStartMsgto fit under the 16-argument limit for the stress log but keep all arguments forSIMPLE_DPRINTFIS_GCSTART%5sTRACE_GCTRACE_GCin_DEBUGbuildsIncludes #108089 until it is merged
Fixes #108628