Skip to content

Update SystemTextJsonToolsetVersion #108704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akoeplinger merged 3 commits into from
Oct 9, 2024
Merged

Update SystemTextJsonToolsetVersion #108704

akoeplinger merged 3 commits into from
Oct 9, 2024

Conversation

@am11
Copy link
Member

@am11 am11 commented Oct 9, 2024

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Oct 9, 2024
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Oct 9, 2024

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@am11 am11 requested review from ilonatommy and maraf as code owners October 9, 2024 11:10
@build-analysis build-analysis bot mentioned this pull request Oct 9, 2024
Closed
3 tasks
@am11
Copy link
Member Author

am11 commented Oct 9, 2024

The one new failure in wasi-wasm leg is [EXECUTION TIMED OUT] Exit Code:-3Executor timed out after 1800 seconds and was killed in socket tests. I doubt it's related to STJ update. Lets merge this to unblock other PRs.

This was referenced Oct 9, 2024
Closed
Closed
@am11
Copy link
Member Author

am11 commented Oct 9, 2024

The two legs github is showing as running were actually timed out on AzDO side:

##[error]We stopped hearing from agent NetCore-Public 99. Verify the agent machine is running and has a healthy network connection. Anything that terminates an agent process, starves it for CPU, or blocks its network access can cause this error. For more information, see: https://go.microsoft.com/fwlink/?linkid=846610

@am11 am11 requested a review from akoeplinger October 9, 2024 14:14
@akoeplinger
Copy link
Member

akoeplinger commented Oct 9, 2024

/ba-g failures are unrelated to the change, merging to unblock the builds.

@akoeplinger akoeplinger merged commit 7318855 into dotnet:main Oct 9, 2024
@am11 am11 deleted the patch-16 branch October 9, 2024 14:57
This was referenced Oct 9, 2024
Closed
Merged
mikem8361 pushed a commit to dotnet/diagnostics that referenced this pull request Oct 9, 2024
@am11
Update SystemTextJsonVersion (#4988)
83d13bc 
Fix:

```sh
$ ./build.sh
...
dotnet-install: To check the list of dependencies, go to https://learn.microsoft.com/dotnet/core/install, select your operating system and check the "Dependencies" section.
Restore complete (43.7s)
  diagnostics failed with 19 error(s) (86.1s)
    /foo77/diagnostics/src/Microsoft.Diagnostics.DebugServices.Implementation/Microsoft.Diagnostics.DebugServices.Implementation.csproj : error NU1903: Warning As Error: Package 'System.Text.Json' 8.0.4 has a known high severity vulnerability, GHSA-8g4q-xg66-9fp4
    /foo77/diagnostics/src/SOS/SOS.Extensions/SOS.Extensions.csproj : error NU1903: Warning As Error: Package 'System.Text.Json' 8.0.4 has a known high severity vulnerability, GHSA-8g4q-xg66-9fp4
    /foo77/diagnostics/src/Tools/dotnet-symbol/dotnet-symbol.csproj : error NU1903: Warning As Error: Package 'System.Text.Json' 6.0.9 has a known high severity vulnerability, GHSA-8g4q-xg66-9fp4
    /foo77/diagnostics/src/Tools/dotnet-trace/dotnet-trace.csproj : error NU1903: Warning As Error: Package 'System.Text.Json' 8.0.4 has a known high severity vulnerability, GHSA-8g4q-xg66-9fp4
    /foo77/diagnostics/src/Tools/dotnet-counters/dotnet-counters.csproj : error NU1903: Warning As Error: Package 'System.Text.Json' 8.0.4 has a known high severity vulnerability, GHSA-8g4q-xg66-9fp4
    /foo77/diagnostics/src/Tools/dotnet-dsrouter/dotnet-dsrouter.csproj : error NU1903: Warning As Error: Package 'System.Text.Json' 6.0.0 has a known high severity vulnerability, GHSA-8g4q-xg66-9fp4
    /foo77/diagnostics/src/Microsoft.Diagnostics.Monitoring.EventPipe/Microsoft.Diagnostics.Monitoring.EventPipe.csproj : error NU1903: Warning As Error: Package 'System.Text.Json' 8.0.4 has a known high severity vulnerability, GHSA-8g4q-xg66-9fp4
```

related PR dotnet/runtime#108704
rzikm pushed a commit to rzikm/dotnet-runtime that referenced this pull request Oct 11, 2024
@am11 @rzikm
Update SystemTextJsonToolsetVersion (dotnet#108704)
d07470a
@cshung cshung mentioned this pull request Oct 14, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ilonatommy ilonatommy ilonatommy left review comments

@akoeplinger akoeplinger akoeplinger approved these changes

@jakobbotsch jakobbotsch jakobbotsch approved these changes

@maraf maraf Awaiting requested review from maraf maraf is a code owner

+2 more reviewers

@tomeksowi tomeksowi tomeksowi approved these changes

@sirntar sirntar sirntar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Infrastructure-libraries community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@am11 @akoeplinger @tomeksowi @jakobbotsch @ilonatommy @sirntar