[LoongArch64] Sync with PR#107282: Transfer arguments between calling conventions in shuffling thunks. #109102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… conventions in shuffling thunks. * Set `varDsc->lvIsMultiRegArg = true` when passing struct with two regs in Compiler::lvaInitUserArgs() to avoid changing passing struct with two regs into one regs in Prolog.
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @mangod9 |
Contributor
Author
|
@tomeksowi Thanks very much for your notification and information. |
tomeksowi
approved these changes
Oct 22, 2024
Member
tomeksowi
left a comment
tomeksowi
left a comment
There was a problem hiding this comment.
LGTM, some cleanup possible.
Member
|
@dotnet/jit-contrib Could you please sign off on the JIT change? |
Also set 'varDsc->lvIsMultiRegArg = true' in 'Compiler::lvaInitUserArgs()' when passing struct with multi regs for RiscV64.
jakobbotsch
approved these changes
Oct 24, 2024
Member
|
@jkotas Does the VM side look good to you? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[LoongArch64] Sync with PR#107282: Transfer arguments between calling conventions in shuffling thunks.