Exclude shared libs from ilcframework in nupkg#109253
Exclude shared libs from ilcframework in nupkg#109253MichalStrehovsky merged 1 commit intodotnet:mainfrom
Conversation
ghost
added
the
needs-area-label
dotnet-policy-service
Bot
added
the
community-contribution
am11
added
area-NativeAOT-coreclr
and removed
needs-area-label
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
MichalStrehovsky
left a comment
MichalStrehovsky
left a comment
There was a problem hiding this comment.
Thanks! I'm not going to merge this just yet because we're trying to get dotnet/sdk#43015 in and this is the kind of change that will only be tested in the sdk repo and if there's a problem, it's going to delay things.
| <ItemGroup Condition="'$(PackageTargetRuntime)' != ''"> | ||
| <File Include="@(LibrariesRuntimeFiles)" TargetPath="framework" /> | ||
| <!-- exclude shared libs as we only need static ones --> | ||
| <LibPackageExcludes Include="framework\%2A%2A\%2A$(LibSuffix)"/> |
There was a problem hiding this comment.
@am11 I think this is breaking in dotnet/sdk#44751, we see lots of failures like
C:\h\w\9AF40878\t\dotnetSdkTests\ybuooc24.wa2.nuget\packages\microsoft.dotnet.ilcompiler\10.0.0-alpha.1.24558.9\build\Microsoft.NETCore.Native.Publish.targets(78,5): error : The FrameworkAssemblies ItemGroup is required for _ComputeAssembliesToCompileToNative
I think this is because we're now excluding .dll on Windows since that is the LibSuffix there but that also means no managed assemblies are included anymore.
There was a problem hiding this comment.
Fixed #109676. We only need to exclude Native.dll etc.
This reverts commit 443f63d.
3 participants
#108649 (comment)
shaves off 1MB from runtime pack on osx; before
39M artifacts/packages/Release/Shipping/runtime.osx-arm64.Microsoft.DotNet.ILCompiler.10.0.0-dev.nupkgnow 38M.