Skip to content

Generate build metadata for illink#109376

Merged
ViktorHofer merged 3 commits intodotnet:mainfrom
am11:feature/gen-build-metadata
Oct 31, 2024
Merged

Generate build metadata for illink#109376
ViktorHofer merged 3 commits intodotnet:mainfrom
am11:feature/gen-build-metadata

Conversation

@am11
Copy link
Copy Markdown
Member

@am11 am11 commented Oct 30, 2024

One way to fix #109335.

@ghost ghost added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Oct 30, 2024
@dotnet-policy-service dotnet-policy-service Bot added linkable-framework Issues associated with delivering a linker friendly framework community-contribution Indicates that the PR has been added by a community member labels Oct 30, 2024
@am11 am11 requested a review from ViktorHofer October 30, 2024 16:44
Comment thread src/tools/illink/src/ILLink.Tasks/ILLink.Tasks.csproj Outdated
Comment thread src/tools/illink/src/ILLink.Tasks/ILLink.Tasks.csproj Outdated
Comment thread src/tools/illink/src/ILLink.Tasks/ILLink.Tasks.csproj Outdated
@ViktorHofer
Copy link
Copy Markdown
Member

ViktorHofer commented Oct 30, 2024

Looks good so far. Please keep this tightly scoped to what we need here for ILLink.Tasks. We can always expand later.

Comment thread src/tools/illink/src/ILLink.Tasks/ILLink.Tasks.csproj Outdated
Comment thread src/tools/illink/src/ILLink.Tasks/build/Microsoft.NET.ILLink.Tasks.props Outdated
Comment thread src/tools/illink/src/ILLink.Tasks/ILLink.Tasks.csproj Outdated
Comment thread src/tools/illink/src/ILLink.Tasks/ILLink.Tasks.csproj
@am11 am11 force-pushed the feature/gen-build-metadata branch from 784c393 to 96c7f3f Compare October 30, 2024 19:20
@am11 am11 marked this pull request as ready for review October 30, 2024 19:50
@am11 am11 requested a review from sbomer as a code owner October 30, 2024 19:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Tools-ILLink .NET linker development as well as trimming analyzers community-contribution Indicates that the PR has been added by a community member linkable-framework Issues associated with delivering a linker friendly framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid hardcoded TFM in illink

3 participants