[mono] Check in offsets files used for AOT cross compilers#109612
Merged
akoeplinger merged 1 commit intodotnet:mainfrom Nov 8, 2024
Merged
[mono] Check in offsets files used for AOT cross compilers#109612akoeplinger merged 1 commit intodotnet:mainfrom
akoeplinger merged 1 commit intodotnet:mainfrom
Conversation
akoeplinger
requested review from
steveisok,
thaystg and
vitek-karas
as code owners
ghost
added
the
steveisok
approved these changes
Nov 7, 2024
Member
steveisok
left a comment
steveisok
left a comment
There was a problem hiding this comment.
nice! This will help for the local build too when dealing with windows / android, for example.
This allows us to remove a join point in the VMR build. Instead of generating the offsets during the AOT cross compiler build we use the checked in files and change the existing CI job to validate that the generated file matches the checked in ones. Fixes dotnet/source-build#3701
akoeplinger
force-pushed
the
offsets-files
branch
from
7b0c97b to
b349128
Compare
This was referenced Nov 7, 2024
Member
Author
|
/ba-g timeouts are unrelated to the PR changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to remove a join point in the VMR build. Instead of generating the offsets during the AOT cross compiler build we use the checked in files and change the existing CI job to validate that the generated file matches the checked in ones.
Fixes dotnet/source-build#3701