Skip to content

Update trimmer attributes for ComActivator#109655

Merged
akoeplinger merged 2 commits intodotnet:mainfrom
AaronRobinsonMSFT:update_annotations
Nov 9, 2024
Merged

Update trimmer attributes for ComActivator#109655
akoeplinger merged 2 commits intodotnet:mainfrom
AaronRobinsonMSFT:update_annotations

Conversation

@AaronRobinsonMSFT
Copy link
Copy Markdown
Member

Also removed unnecessary logging.

Related to dotnet/sdk#44751.

/cc @sbomer

@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

@sbomer
Copy link
Copy Markdown
Member

sbomer commented Nov 8, 2024

I see that we also do a lookup for other COM attributes in GetDataForComInvocation and GenerateProgIdForType - I think those should be annotated as well, to avoid IL2045 warnings for the following program:

using System.Runtime.InteropServices;

Marshal.GenerateProgIdForType(null);
new ComAwareEventInfo(null, null).AddEventHandler(null, null);

Copy link
Copy Markdown
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@akoeplinger
Copy link
Copy Markdown
Member

/ba-g timeouts are unrelated to the changes.

@akoeplinger
Copy link
Copy Markdown
Member

Merging to unblock sdk flow.

@akoeplinger akoeplinger merged commit 19cd424 into dotnet:main Nov 9, 2024
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the update_annotations branch November 9, 2024 16:34
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this pull request Dec 10, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants