Change assertion in IPGlobalProperties_DomainName_ReturnsEmptyStringWhenNotSet #110070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Contributor
|
Tagging subscribers to this area: @dotnet/ncl |
simonrozsival
approved these changes
Nov 22, 2024
wfurt
reviewed
Nov 22, 2024
| Assert.Equal(string.Empty, gp.DomainName); | ||
|
|
||
| // [ActiveIssue("https://github.com/dotnet/runtime/issues/109280")] | ||
| string expectedDomainName = PlatformDetection.IsAndroid ? "localdomain" : string.Empty; |
Member
There was a problem hiding this comment.
I'm not sure if we re4ally need the comment but I'm OK keeping it.
wfurt
approved these changes
Nov 22, 2024
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephentoub
approved these changes
Dec 5, 2024
Contributor
Author
|
/azp run runtime-libraries-mono outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Outerloop failures are unrelated. |
hez2010
pushed a commit
to hez2010/runtime
that referenced
this pull request
Dec 14, 2024
…henNotSet (dotnet#110070) Accept "localdomain" as a valid DomainName on Android.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #109280. Given that we don't seem to understand the reason the value is
localdomain, this change feels like a test hack instead of an actual fix, thus theActiveIssuelink. If we don't care that much, I'm happy to delete the comment and close the issue.