[S390x] Fix endian bug in minipal#110985
Merged
jkoritzinsky merged 1 commit intodotnet:mainfrom Dec 30, 2024
Merged
Conversation
Contributor
Author
|
cc: @jkoritzinsky |
jkoritzinsky
approved these changes
Dec 30, 2024
Contributor
Author
|
can this be merged? |
iii-i
pushed a commit
to IBM/dotnet-s390x
that referenced
this pull request
Jan 2, 2025
backport fixes dotnet/runtime#110985 dotnet/runtime#107559 add mandatory dependency in DockerFile dotnet/runtime#109681 dotnet/arcade#15233 Signed-off-by: Sanjam Panda <sanjam.panda@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
after #107889 is merged we see test cases crashing on s390x
This is primarily because the "BIGENDIAN" macro is defined in
src/native/minipal/minipalconfig.h.inwhich generates aminipalconfig.hwhich needs to be included inutf8.cin order for the macro to be used there.