Fix exception stack pretty printing in the presence of missing dependencies #111476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Member
Author
|
Found in #111311 (comment) |
Contributor
|
Tagging subscribers to this area: @tommcdon |
jkotas
commented
Jan 15, 2025
| // Getting the attributes has failed, return null. One of the reasons | ||
| // can be that the member has attributes defined in an assembly that is missing. | ||
| return []; | ||
| return null; |
Member
Author
There was a problem hiding this comment.
Caller casts this to StateMachineAttribute[]. Casting empty Attribute[] to StateMachineAttribute[] was guaranteed to fail.
Member
Author
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/libraries/System.Private.CoreLib/src/System/Diagnostics/StackTrace.cs:421
- The change to return null instead of an empty array should be covered by tests to ensure that the new behavior is correctly handled.
private static Attribute[]? GetCustomAttributesSafe(MemberInfo memberInfo, Type attributeType, bool inherit)
Contributor
|
Oops, thanks! |
This was referenced Jan 16, 2025
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.