Skip to content

Move the diagnostic print for stack overflow test failure #112001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janvorli merged 1 commit into from
Jan 31, 2025
+2 −2
Merged

Move the diagnostic print for stack overflow test failure #112001

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/coreclr/pal/src/exception/signal.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,7 @@ static bool SwitchStackAndExecuteHandler(int code, siginfo_t *siginfo, void *con
// Temporary locals to debug issue https://github.com/dotnet/runtime/issues/110173
static SIZE_T stackOverflowThreadId = -1;
static const char StackOverflowOnTheSameThreadMessage[] = "Stack overflow occurred on the same thread again!\n";
static const char StackOverflowHandlerReturnedMessage[] = "Stack overflow handler has returned!\n";
static const char StackOverflowHandlerReturnedMessage[] = "Stack overflow handler has returned, invoking previous action!\n";
//

/*++
Expand Down Expand Up @@ -669,9 +669,9 @@ static void sigsegv_handler(int code, siginfo_t *siginfo, void *context)

if (SwitchStackAndExecuteHandler(code | StackOverflowFlag, siginfo, context, (size_t)handlerStackTop))
{
(void)!write(STDERR_FILENO, StackOverflowHandlerReturnedMessage, sizeof(StackOverflowHandlerReturnedMessage) - 1);
PROCAbort(SIGSEGV, siginfo);
}
(void)!write(STDERR_FILENO, StackOverflowHandlerReturnedMessage, sizeof(StackOverflowHandlerReturnedMessage) - 1);
}
else
{
Expand Down